296749 - Plugin placeholders not rendered on reload

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

The first time I visit that url, I can see the plugin placeholder at the top of
the page, but when I do a reload, I can't see the plugin placeholder anymore.
When I click on the empty space where the placeholder should be, it suddenly
appears. 
I'll attach a testcase. 
This behavior started when the new plugin placeholder was checked into the trunk.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: Testcase

Text before the <object> code causes the bug _not_ to appear, so that's why the
previous testcase wasn't working.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

seems to work in my build with the patch for bug 1156

Comment 4

[Boris Zbarsky [:bzbarsky]]

Martijn, is this still an issue in current builds?

Comment 5

[Martijn Wargers (dead)]

Ehm, I'm seeing no plugin finder at all with the testcase, using a 2006-01-05 trunk build. I should see one with the testcase now, shouldn't I?

Comment 6

[Caleb]

(In reply to comment #5)
> Ehm, I'm seeing no plugin finder at all with the testcase, using a 2006-01-05
> trunk build. I should see one with the testcase now, shouldn't I?
> 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060106 Firefox/1.6a1 ID:2006010604

I see the plugin finder, but no plugin placeholder.

Comment 7

[Martijn Wargers (dead)]

Yes, sorry, I meant the plugin placeholder in comment 5.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

which browser are you using? hm... actually this works for me in both firefox and seamonkey.

Comment 9

[Martijn Wargers (dead)]

(In reply to comment #8)
> which browser are you using?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060105 Firefox/1.6a1

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, maybe my ffox tree is too old...

Comment 11

[Boris Zbarsky [:bzbarsky]]

Worksforme also with my Firefox debug build from MOZ_CO_DATE="Tue Jan 3 21:50:11 CST 2006". But doesn't work with 2006-01-03-05 or 2006-01-04-05 nightlies from mozilla.org.  Are the nightlies not shipping part of the fix from bug 309521?

Comment 12

[Boris Zbarsky [:bzbarsky]]

So.... pluginGlue.js is built, but it's not in the components/ directory of the tarballs we ship.  

Do we need to list pluginGlue.js in a .pkg file somewhere?  And probably in the various xpinstall package lists?

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, I suck...

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: package pluginGlue.js

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: merged to trunk

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

patch checked in. that should make this fixed.

Checking in browser/installer/unix/packages-static;
/cvsroot/mozilla/browser/installer/unix/packages-static,v  <--  packages-static
new revision: 1.63; previous revision: 1.62
done
Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v  <--  packages-static
new revision: 1.67; previous revision: 1.66
done
Checking in mail/config/basemail-unix;
/cvsroot/mozilla/mail/config/basemail-unix,v  <--  basemail-unix
new revision: 1.33; previous revision: 1.32
done
Checking in mail/installer/windows/packages-static;
/cvsroot/mozilla/mail/installer/windows/packages-static,v  <--  packages-static
new revision: 1.16; previous revision: 1.15
done