Closed
Bug 296940
Opened 19 years ago
Closed 19 years ago
Update Changes Cause Thunderbird to Enter an Infinite Loop
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: tracy, Assigned: mscott)
References
Details
(Keywords: hang, regression, smoketest)
Attachments
(1 file, 1 obsolete file)
6.49 KB,
patch
|
Details | Diff | Splinter Review |
Seen on Mac Thunderbird build 2005-06-07-05-trunk -Clear out profile -Launch app. -Click anything in the Migration dialog Hang with spinning rainbow wheel. -Force quit and attempt to launch again. nothing happens -restart Computer -Launch Tbird again. -click "Cancel" and "Exit" to get out of the account setup dialog (or go through account setup completely) -click on the App Hang with spinning rainbow wheel. Note: The Mac Tbird build from 2005-06-06 did not display this problem
Reporter | ||
Comment 1•19 years ago
|
||
linux build just came out. It is useable, but the following message is repreated endlessly in the command line terminal: *** Checker.onError: error during load *** update url: chrome://mozapps/locale/update/update.properties *** Checker.findUpdates: sending request to chrome://mozapps/locale/update/update.properties I don't know if it is related to the hang on Mac. Just fyi.
Comment 2•19 years ago
|
||
yeah, I also see the tons off errors from comment 1 (linux fc3, 2005060706-trunk tbird).
Comment 3•19 years ago
|
||
another observation: the spewing comments affects performance, too, since I noticed that the response is a bit slower --but more annoyingly the pointer is now always flickering.
Comment 4•19 years ago
|
||
let me know if I should file a separate bug on the flickering pointer/perf issue. it really interfere's with using the app.
Updated•19 years ago
|
OS: MacOS X → All
Hardware: Macintosh → All
Assignee | ||
Comment 5•19 years ago
|
||
cc'ing Ben and Darin. I'm pretty sure all these update errors are from the big software update landing that happened yesterday.
Assignee | ||
Comment 6•19 years ago
|
||
Even if I'm not migrating, just starting Thunderbird up with an existing profile. The mail 3-pane comes up but you can't do anything because we are in some sort of infinite loop with the update service. Console keeps spewing out the forementioned errors: *** Checker.onError: error during load *** update url: chrome://mozapps/locale/update/update.properties *** Checker.findUpdates: sending request to chrome://mozapps/locale/update/updat e.properties *** Checker.onError: error during load *** update url: chrome://mozapps/locale/update/update.properties *** Checker.findUpdates: sending request to chrome://mozapps/locale/update/updat e.properties
Updated•19 years ago
|
Summary: Hangs in migration dialog → Hangs in migration dialog, pointer flickers
Assignee | ||
Comment 7•19 years ago
|
||
Looks like some XBL bindings in update.xml went away without anyone fixing up Thunderbird to not use these bindings anymore. That expains some of the XBL prototype binding errors I'm getting. I've been able to fix those but I still see the infinite update loop.
Summary: Hangs in migration dialog, pointer flickers → Update Changes Cause Thunderbird to Enter an Infinite Loop
Assignee | ||
Comment 8•19 years ago
|
||
Another problem, updates.properties which is defined in mozilla\toolkit sets: app.update.url=https://aus.mozilla.org/update/firefox/en-US.rdf Surely that's not right? I'm pretty sure Thunderbird shouldn't be running against Firefox's en-US.rdf file on the update server. Not sure if that is related to the infinite update check.
Assignee | ||
Comment 9•19 years ago
|
||
it looks like it's loading the actual properties file for app.update.url instead of getting the localized pref value of app.update.url. From nsUpdateService.js.in: get _updateURL() { try { //return gPref.getComplexValue(PREF_APP_UPDATE_URL, nsIPrefLocalizedString).data; return gPref.getCharPref(PREF_APP_UPDATE_URL); } where PREF_APP_UPDATE is defined as app.update.url which is in all-thunderbird/all-firefox.js as chrome://mozapps/locale/update/update.properties I'm hoping one of you guys (darin/ben?) are going to jump in here and help figure this smoketest blocker out. Seems pretty clear to me that we never tested Thunderbird before checking this in yesterday which is a pretty big no no for something of this size and is clearly stated on the Tinderbox rules. You guys should know better :)
Assignee | ||
Comment 10•19 years ago
|
||
1) Incomplete patch that gets rid of some XBL widgets (statusbar-update) in Thunderbird which were removed from updates.xml as part of the update landing yesterday. 2) Trys to mimic the preference changes made to all-firefox.js as part of yesterday's update landing. 3) port the CSS changes from winstripe's update.css to qute's update.css With these changes I still have the same problems reported above. This patch does get rid of the XBL prototype binding assertions because our widget was removed from underneath us.
Assignee | ||
Comment 11•19 years ago
|
||
I think this patch fixes the infinite loop. The timer was firing over and over again to constantly try to update. Now we get just the one error the first time we try to update and we don't do it again.
Attachment #185602 -
Attachment is obsolete: true
Comment 12•19 years ago
|
||
Note also: bug 296972 (for XULRunner)
Assignee | ||
Comment 13•19 years ago
|
||
I checked in the ported changes whidch I think fixes the problem.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•19 years ago
|
||
Verified on Mac and Linux Tbird trunk builds from 2005-06-08
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•