Closed
Bug 297124
Opened 19 years ago
Closed 19 years ago
mar.exe fails to link with Microsoft Visual Studio 2005 Beta 2
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stdowa+bugzilla, Unassigned)
References
()
Details
Attachments
(1 file)
571 bytes,
patch
|
stdowa+bugzilla
:
review+
|
Details | Diff | Splinter Review |
Starting with Visual Studio 2005, Microsoft is only shipping the multithreaded libs for the CRT.
Reporter | ||
Comment 1•19 years ago
|
||
Darin gave a verbal r+ for this bustage fix.
Attachment #185717 -
Flags: review+
Attachment #185717 -
Flags: approval1.8b3?
Comment on attachment 185717 [details] [diff] [review] Only use the single-threaded CRT for VC6-VC7.1 Please use - instead of / or you will break the msys builds.
Comment 3•19 years ago
|
||
Comment on attachment 185717 [details] [diff] [review] Only use the single-threaded CRT for VC6-VC7.1 bustage fix; check it in :)
Reporter | ||
Comment 4•19 years ago
|
||
I built with msys, but didn't break with the patch which is strange. Consistency is better though since all the Makefiles have been converted.
Comment 5•19 years ago
|
||
fixed-on-trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•19 years ago
|
||
Comment on attachment 185717 [details] [diff] [review] Only use the single-threaded CRT for VC6-VC7.1 Clearing approval1.8b3?
Attachment #185717 -
Flags: approval1.8b3?
My VC build that uses the setup from http://whereswalden.com/mozilla/msvcfree/ fails with the checked in patch. _MSC_VER is 1310. Why do we use those flags anyway? cygcheck doesn't show any difference if I remove those ifdefs completely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The problem was fixed with the checkin for bug 299557.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•