297124 - mar.exe fails to link with Microsoft Visual Studio 2005 Beta 2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Stephen Walker]

Starting with Visual Studio 2005, Microsoft is only shipping the multithreaded
libs for the CRT.

Comment 1

[Stephen Walker]

Attachment: Only use the single-threaded CRT for VC6-VC7.1

Darin gave a verbal r+ for this bustage fix.

Comment 2

[cls]

Comment on attachment 185717 [details] [diff] [review]
Only use the single-threaded CRT for VC6-VC7.1

Please use - instead of / or you will break the msys builds.

Comment 3

[Darin Fisher]

Comment on attachment 185717 [details] [diff] [review]
Only use the single-threaded CRT for VC6-VC7.1

bustage fix; check it in :)

Comment 4

[Stephen Walker]

I built with msys, but didn't break with the patch which is strange. 
Consistency is better though since all the Makefiles have been converted.

Comment 5

[Darin Fisher]

fixed-on-trunk

Comment 6

[Stephen Walker]

Comment on attachment 185717 [details] [diff] [review]
Only use the single-threaded CRT for VC6-VC7.1

Clearing approval1.8b3?

Comment 7

[cls]

My VC build that uses the setup from http://whereswalden.com/mozilla/msvcfree/
fails with the checked in patch.  _MSC_VER is 1310. Why do we use those flags
anyway?  cygcheck doesn't show any difference if I remove those ifdefs completely.

Comment 8

[cls]

The problem was fixed with the checkin for bug 299557.