297496 - xul error on main window, <menuitem id="context-savelink" appears on bottom of main window

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Matthew Imakyure]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050611 Firefox/1.0+
Build Identifier: Mozilla Thunderbird 20050612

error shows up on bottom of main mail window

      <menuitem id="context-savelink"
______^

Reproducible: Always

Steps to Reproduce:
1. start Thunderbird
2.
3.
Actual Results:  
error shows up near bottom of window

Expected Results:  
window without error

Comment 1

[Peter Lairo]

confirming on version 1.0+ (20050612), win2k

Matthew Imakyure: Could you please mark this bug as:
Severity = MAJOR
Keyword  = REGRESSION

Comment 2

[Magnus Melin [:mkmelin]]

This is linux (20050612 and 20050613) also. And mac (according to the mz forums). 

Comment 3

[Grayson Mixon (ColdFusion650)]

it regressed sometime between 2005-06-11-09 and 2005-06-12-08. heres the link to
the checkins in that time:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-06-11+09%3A00%3A00&maxdate=2005-06-12+08%3A00%3A00&cvsroot=%2Fcvsroot

Comment 4

[Grayson Mixon (ColdFusion650)]

here's also a link to all the files that make reference to <menuitem
id="context-savelink"

http://lxr.mozilla.org/seamonkey/search?string=%3Cmenuitem+id%3D%22context-savelin

Comment 5

[Scott MacGregor]

getting rid of the unnecessary 1.04 nomination. This has nothing to do with the
1.0 branch.

Comment 6

[Grayson Mixon (ColdFusion650)]

mscott, can u figure out what cause this? i cant see any relation between the
files that could cause the error, and the checkins made during the regression
window.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

It's my fault and I'm working on a fix.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

fix.

I removed xpfe's contentAreaCommands.dtd which is different from mail's one
(mail's one was overwrited by xpfe's one).
This patch adds missing bits from xpfe's contentAreaCommands.dtd which are used
by 
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/contentAreaContextOverlay.xul

Comment 9

[Scott MacGregor]

Comment on attachment 186126 [details] [diff] [review]
patch

fix the new line if you can too.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Checking in mail/locales/en-US/chrome/communicator/contentAreaCommands.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/communicator/contentAreaCommands.dtd,v
 <--  contentAreaCommands.dtd
new revision: 1.3; previous revision: 1.2
done

Comment 11

[Robert Strong (they/them - no direct email)]

*** Bug 297589 has been marked as a duplicate of this bug. ***

Comment 12

[Tracy Walker [:tracy]]

verified with Windows trunk build 2005-07-01-08-trunk