297503 - Useless autoscroll code?

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Martijn Wargers (dead)]

I think I've found some autoscroll code that is absolutely useless and could be
performance undermining.
After removing this code, simultaneous downwards and sideways scrolling seems
smoother than before.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This is the code I was talking about.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 186052 [details] [diff] [review]
patch

Its not useless, in the sense that it cuts down on the amount of painting
required for each increment.  Yes, its less smooth, and scrolls slower, but it
eats less CPU as well.

At the same time, this code is at least two or three years old, and we're a
consumer update cycle farther along, so lets drop this, and revisit if it
really horks CPU-deficient users.

Comment 3

[Martijn Wargers (dead)]

Attachment: patchv2

Ah, ok. Thanks for the info.
That previous patch indeed did make the autoscroll go faster.
This patch should take care of that.
The minimum value that can be used in Mozilla is 10ms, see bug 123273. That's
why I went from 5 to 20 ms.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 186106 [details] [diff] [review]
patchv2

Mike, sorry, again asking for review...

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 186106 [details] [diff] [review]
patchv2

r=me for trunk only at this point, but if we can get some reliable testing on
the trunk regarding the potential perf hit vs. the jerkiness, I think this is
quite branch-safe.

Comment 6

[Martijn Wargers (dead)]

Attachment: patchv2b ready for checkin

This one applies to current trunk

Comment 7

[Martijn Wargers (dead)]

checked in by bz.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/browser.xml; new revision: 1.70.2.7;
mozilla/toolkit/content/widgets/preferences.xml; new revision: 1.31.2.10;
mozilla/toolkit/content/widgets/textbox.xml; new revision: 1.21.4.2;

Comment 9

[Steffen Wilberg]

Gavin, you also landed the patch for preferences.xml from bug 315195:
http://bonsai.mozilla.org/cvsquery.cgi?module=AviaryBranchTinderbox&branch=&date=explicit&mindate=2006-02-02+14%3A53&maxdate=2006-02-02+14%3A53

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> Gavin, you also landed the patch for preferences.xml from bug 315195:
> http://bonsai.mozilla.org/cvsquery.cgi?module=AviaryBranchTinderbox&branch=&date=explicit&mindate=2006-02-02+14%3A53&maxdate=2006-02-02+14%3A53

Doh, thanks for noticing Steffen, trying to keep track of the state of my branch tree has been rather difficult. Luckily that one already had approval (from dveditz and mconnor over IRC) so I'll just mark that bug.