Closed Bug 297503 Opened 17 years ago Closed 17 years ago

Useless autoscroll code?


(Toolkit :: XUL Widgets, defect)

Not set





(Reporter: martijn.martijn, Assigned: martijn.martijn)


(Keywords: fixed1.8.1)


(2 files, 1 obsolete file)

I think I've found some autoscroll code that is absolutely useless and could be
performance undermining.
After removing this code, simultaneous downwards and sideways scrolling seems
smoother than before.
Attached patch patch (obsolete) — Splinter Review
This is the code I was talking about.
Attachment #186052 - Flags: first-review?(mconnor)
Comment on attachment 186052 [details] [diff] [review]

Its not useless, in the sense that it cuts down on the amount of painting
required for each increment.  Yes, its less smooth, and scrolls slower, but it
eats less CPU as well.

At the same time, this code is at least two or three years old, and we're a
consumer update cycle farther along, so lets drop this, and revisit if it
really horks CPU-deficient users.
Attachment #186052 - Flags: first-review?(mconnor) → first-review+
Attached patch patchv2Splinter Review
Ah, ok. Thanks for the info.
That previous patch indeed did make the autoscroll go faster.
This patch should take care of that.
The minimum value that can be used in Mozilla is 10ms, see bug 123273. That's
why I went from 5 to 20 ms.
Comment on attachment 186106 [details] [diff] [review]

Mike, sorry, again asking for review...
Attachment #186106 - Flags: first-review?(mconnor)
Comment on attachment 186106 [details] [diff] [review]

r=me for trunk only at this point, but if we can get some reliable testing on
the trunk regarding the potential perf hit vs. the jerkiness, I think this is
quite branch-safe.
Attachment #186106 - Flags: first-review?(mconnor) → first-review+
Attachment #186052 - Attachment is obsolete: true
This one applies to current trunk
checked in by bz.
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #196359 - Flags: branch-1.8.1?(mconnor)
Attachment #196359 - Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/browser.xml; new revision:;
mozilla/toolkit/content/widgets/preferences.xml; new revision:;
mozilla/toolkit/content/widgets/textbox.xml; new revision:;
Keywords: fixed1.8.1
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8.1
(In reply to comment #9)
> Gavin, you also landed the patch for preferences.xml from bug 315195:

Doh, thanks for noticing Steffen, trying to keep track of the state of my branch tree has been rather difficult. Luckily that one already had approval (from dveditz and mconnor over IRC) so I'll just mark that bug.
You need to log in before you can comment on or make changes to this bug.