315195 - Select wrong default font if I close the preferences window with Command + W shortcut

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[pierren]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

When I close the preferences window with the shortcut and the Content section is activated, the default font switch back to Webdings, always. If I close the window with the mouse, everything works fine

Reproducible: Always

Steps to Reproduce:
1.Open preferences window
2.Select "Content" section
3.Choose a default font other than Webdbings
4.Close window with shortcut (Command + W)

Actual Results:  
I can't read my web pages because the font is set to Webdings

Expected Results:  
The font should stay to the one I selected before closing the window

Comment 1

[Hiro]

Confirm.

Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051104 Firefox/1.6a1

Comment 2

[Josh Aas]

*** Bug 318137 has been marked as a duplicate of this bug. ***

Comment 3

[Asaf Romano (gone)]

So, since <prefwindow> implements Accel+W as a <xul:key>, the menulist captures "W" before the window is closed.

Comment 4

[Asaf Romano (gone)]

*** Bug 318140 has been marked as a duplicate of this bug. ***

Comment 5

[Asaf Romano (gone)]

Attachment: patch

(note: instantApply is always off in child-prefwindows).

Comment 6

[Asaf Romano (gone)]

Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.44; previous revision: 1.43
done

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 204527 [details] [diff] [review]
patch

annoying but minor with a workaround, and patch affects all platforms.

After more trunk (and 1.8.1-branch) baking might consider for a 1.8.0.2

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I accidentally landed this on the 1.8 branch yesterday with bug 297503. Marking fixed1.8.1 accordingly.