297788 - CVS account request Dirk Mueller for Firefox/Qt

Status: RESOLVED INCOMPLETE

(mozilla.org :: Repository Account Requests, task)

Description

[Dirk Mueller]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.4; Linux) KHTML/3.4.89 (like Gecko)
Build Identifier: 

I'd like to request a CVS account for improving the Qt toolkit port of Mozilla 
in cooperation with Zack Rusin <[e-mail]>.  
 
 

Reproducible: Always

Comment 1

[Dirk Mueller]

Attachment: ssh key

Comment 2

[Zack Rusin]

Dirk's one of the best KDE developers. He's got tremendous experience with
writing browsers and is a very reliable engineer. 
I'm vouching for Dirk.

Comment 3

[Marcia Knous [:marcia]]

Need the CVS form  - www.mozilla.org/hacking/form.html

Comment 4

[Dirk Mueller]

FAXed the form. 

Comment 5

[Dirk Mueller]

I don't think I need super-reviewal because I'll be only touching 
things inside the qt/* subdirs.  
 
 

Comment 6

[Mike Connor [:mconnor]]

So you're not going to touch the UI bits that control button ordering/theme
tweaks or anything else outside of the widget code?  I really doubt that'd last,
unless KDE is going to switch to GNOME-style bits in dialogs, etc.

Comment 7

[Dirk Mueller]

currently some of the dialogs are natively implemented in Qt, so they have the 
"right" button ordering already. If we're there that I'll have time to care 
about those issues, then I'll ask for review.  

Comment 8

[Mike Connor [:mconnor]]

If the SR requirement is waived, then you're expected to restrict all checkins
to the specific area you'll be working within.  In this case, I think its
probably appropriate/desirable to get the three SRs so as to not have to worry
about restrictions.  The exemption is really more intended for NSS, Chatzilla,
and other localized and tightly-owned pieces that don't spill over into core code.

Not trying to be a hardass, just trying to clarify.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Dirk, have you already done any patches, by chance?  Or are there bugs where you
have patches posted right now?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think Dirk has done much yet. But Wolfgang and I can handle his first
few non-Qt checkins and then he can get general CVS access.

Comment 11

[Boris Zbarsky [:bzbarsky]]

That sounds pretty reasonable to me.

Comment 12

[Yves Glodt]

In terms of reducing bureaucracity, mozilla can certainly learn from kde...

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

what is blocking us in this bug?

Comment 14

[Benjamin Smedberg]

Can we see some representative patches (bug numbers)? Reading the bug it doesn't look like drivers have agreed to waive the three-superreview rule here (yet).

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #12)
> In terms of reducing bureaucracity, mozilla can certainly learn from kde...

Why should we give cvs access to people who haven't yet written any patches to Mozilla?

Comment 16

[Boris Zbarsky [:bzbarsky]]

> what is blocking us in this bug?

The fact that we give CVS access to people who've shown they write good code and follow Mozilla procedures.  And Dirk, not having written any code that I know of, hasn't shown that.

Comment 17

[Reed Loden [:reed]]

Due to a recent overhaul of the committer's agreement, we are requiring new forms be sent for accounts that have yet to be created, even if you have already filled out and submitted the old CVS Contributor Form. Please download the form at http://www.mozilla.org/hacking/committer/committers-agreement.pdf and submit it according to the directions specified at http://www.mozilla.org/hacking/notification/. We apologize for this necessary inconvenience. If you have any questions, feel free to ask. Thanks!

Comment 18

[:Gavin Sharp [email: [e-mail]]]

This request has been inactive for a long time, so closing it out to get it off
the list of open bugs. Feel free to reopen or file a new bug if you're still
interested in access.