297870 - attachments table/list should show attachment creator

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[:glob ✱]

attachments table/list should show attachment creator.

Comment 1

[:glob ✱]

Attachment: v1

adds "creator" column to the attachments table

Comment 2

[:glob ✱]

Comment on attachment 186437 [details] [diff] [review]
v1

i'll change this to do a join to get the submitter name/email instead of
creating a Bugzilla::User object.

Comment 3

[Frédéric Buclin]

Comment on attachment 186437 [details] [diff] [review]
v1

glob, wurblzap told me that derive_groups() is called only when group privs
have changed since the last time this user object was created (I checked this
point and he is right, see User.pm line 133). So it's fine to create a user
object here.

We should move to a unique user identifier (username) as soon as bug 218917 is
fixed.

r=LpSolit

Comment 4

[Frédéric Buclin]

Comment on attachment 186437 [details] [diff] [review]
v1

>+        <td valign="top">
>+          <a href="mailto:[% attachment.submitter.email FILTER html %]">
>+          [% attachment.submitter.name FILTER html %]
>+          </a>
>+        </td>

Maybe should we fall back to the user login if the user has no name:
[% attachment.submitter.name || attachment.submitter.login FILTER html %]

Could you fix that and carry forward my r+ please?

Comment 5

[:glob ✱]

Attachment: v2

falls back to attachment.submitter.login; carrying forward r+

Comment 6

[:glob ✱]

Checking in Bugzilla/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v  <--  Attachment.pm
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.22; previous revision: 1.21
done

Comment 7

[:glob ✱]

*** Bug 349806 has been marked as a duplicate of this bug. ***