Closed Bug 297914 Opened 19 years ago Closed 19 years ago

Use BZ2 packaging for gtk2 builds

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(2 files, 1 obsolete file)

While evaluating toolkit's packager.mk for bug 292268, I noticed we still
package even gtk2 builds with TGZ packaging by default, though all machines
modern enough to have gtk2 should have bzip2 installed.
bzip2 has actually been around much longer than gtk2, but it took some time to
get the more or less standard file compression format in unix land, as which it
can be seen today - at least when looking for compressed package downloads for
linux.

As it gives us better compression (and therfore smaller download sizes) and the
consumers should have it everywhere, I think we should default to BZ2 packaging
for gtk2 builds.

I'll attach a patch shortly.
OK, here's the patch. Not much magic included. I didn't test it in toolkit yet,
but I have tested this part of code in the SeaMonkey makefiles some time ago
(see bug mentioned above).
Attachment #186482 - Flags: first-review?(benjamin)
Comment on attachment 186482 [details] [diff] [review]
use BZ2 by default for gtk2 builds

Chase will need to coordinate some tinderbox with this: it might be helpful if
somebody made a patch to post-mozilla-rel.pl which adds *.tar.bz2 wherever you
see *.tar.gz (or maybe just *.tar.*).
Attachment #186482 - Flags: second-review?(chase)
Attachment #186482 - Flags: first-review?(benjamin)
Attachment #186482 - Flags: first-review+
OK, as trivial as the patch is, I just want to state it doesn't break the
packaging build, because I stated before I didn't test it yet :)

I actually now successfully built a gtk2 Linux package with packager.mk
including this patch, and it ended up being a .tar.bz2 as expected. (Actually, I
tested it for SeaMonkey, but along with my latest patch in bug 292268 which uses
packager.mk)
OK, here's the supplementary tinderbox patch for chase. I changed all *.tar.gz
in post-mozilla-rel.pl to *.tar.* - that should work for both .bz2 (for gtk2
builds) and .gz (for all others) now.
Comment on attachment 186482 [details] [diff] [review]
use BZ2 by default for gtk2 builds

Wait to land this for coordination on mods to the packaging scripts.
Attachment #186482 - Flags: second-review?(chase) → second-review+
So, this is an unbitrotted version of this patch, not sure if it's needed as I
found out that the first hunk failing on my tinderbox uinstall was due to a
different change I made.

Anyways, my "trip" tinderbox on MozillaTest is running gtk2 builds with both
patches applied now and seems to work fine that way (creating the archive as
.tar.bz2 and copying it correctly, also copying the still .tar.gz installer
file correctly).

Chase, could we go forward and get those patches in?
Attachment #187397 - Attachment is obsolete: true
(In reply to comment #6)
> Anyways, my "trip" tinderbox on MozillaTest is running gtk2 builds with both
> patches applied now and seems to work fine that way (creating the archive as
> .tar.bz2 and copying it correctly, also copying the still .tar.gz installer
> file correctly).
> 
> Chase, could we go forward and get those patches in?

Yeah, let's go for it.
(In reply to comment #7)
> (In reply to comment #6)
> > Chase, could we go forward and get those patches in?
> 
> Yeah, let's go for it.

That is, let's go for it on the trunk. :)
Chase:
I guess it's best to first check in the supplementary tinderbox patch and
upgrade the gtk2 trunk tinderboxen to it, and when that's done, check in the
main patch. With that, the boxen never break in the process.

Should I check that post-mozilla-rel patch in, or will you do it?
If I should do it, could you tell me what r= or whatever I should mark?

And could you notify me when the boxen have the patch so I can check in the main
patch?
Comment on attachment 195200 [details] [diff] [review]
supplementary patch for post-mozilla-rel.pl (unbitrotted)

These changes are now present on comet and barcelona for SeaMonkey trunk
builds.
Attachment #195200 - Flags: first-review+
Checked into trunk.

Chase, the trunk Firefox and Thunderbird gtk2 release tinderboxen might need the
tinderbox change as well.

Additionally, should I check in that post-mozilla-rel.pl patch as well?
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
(In reply to comment #11)
> Checked into trunk.
> 
> Chase, the trunk Firefox and Thunderbird gtk2 release tinderboxen might need the
> tinderbox change as well.

Yes, of course.  I updated:

  * Firefox
  * Thunderbird
  * Sunbird
  * Mozilla-l10n (what they pull and what they capture after a build)

There will be respins on the Firefox and Thunderbird Linux build systems to
ensure they produce the expected packages and to ensure we don't heinously break
the trunk l10n repackaging on Linux.

> Additionally, should I check in that post-mozilla-rel.pl patch as well?

That's not necessary.  I did that on your behalf as I was updating these systems
today.
> > Additionally, should I check in that post-mozilla-rel.pl patch as well?
> 
> That's not necessary.  I did that on your behalf as I was updating these systems
> today.

Oh, good. This means that on trunk this should be really fixed now :)
(In reply to comment #13)
> Oh, good. This means that on trunk this should be really fixed now :)

Yeah, in the code this is almost fixed.  I note installer builds are still
tar.gz.  It would be nice to move those over to bz2.

Also, you'll need to find out what weblinks need to be updated to use the bz2
filenames now and coordinate getting those switched over.
> Yeah, in the code this is almost fixed.  I note installer builds are still
> tar.gz.  It would be nice to move those over to bz2.

Yes, I know... Is this true for SeaMonkey only or also for toolkit installer?

> Also, you'll need to find out what weblinks need to be updated to use the bz2
> filenames now and coordinate getting those switched over.

Good catch. I'm not sure where we have weblinks left though other than
http://www.mozilla.org/developer/ - I'll fix that one though as soon as I know
that .bz2 builds are there.
Chase, it seems to me that lhasa is not fixed for this yet, as it didn't upload
a tarball today...
(In reply to comment #14)
> Yeah, in the code this is almost fixed.  I note installer builds are still
> tar.gz.  It would be nice to move those over to bz2.

I filed bug 316548 for that.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: