316548 - Use bzip2 compression for linux installers

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Kaiser]

From bug 297914 comment #14:
"I note installer builds are still tar.gz.  It would be nice to move those over to bz2."

From what I see, Linux installers are generated by toolkit/mozapps/installer/unix/install_sub.pl (toolkit) and xpinstall/packager/unix/deliver*.pl (SeaMonkey). I haven't figured out yet how to detect gtk2 there, so that we can selectively switch to bzip2 for that...

Comment 1

[Robert Kaiser]

Thinking a bit more about this stuff (and about how I might be able to test against gtk2 from perl), I think switching all linux installers over to bzip2 will be the best way. People on really old systems with gtk1 and no bzip2 can use the normal tarballs that are still .gz anyways - and I guess most of them do that. And bzip2 has been shipped with all interesting Linux distros for ages now.

Comment 2

[Robert Kaiser]

Attachment: switch Linux installers to bzip2

This patch should switch both toolkit and SeaMonkey Linux installers to bzip2, I believe :)
BTW, current tinderbox code should already be able to deal with this, as we already patched it for bug 297914 - though gtk1 release boxen (are there any bsides comet?) might not have this yet.

Comment 3

[Robert Kaiser]

Attachment: v2: also create toolkit file names correctly

OK, I just tested making installers in my local trees with the patch, and while SeaMonkey performs correctly, I saw the filename of firefox installer was still wrong, though the format was correct. One further small change to that one line is needed to do it really correctly. This is fixed in this second patch :)

To make it short, this patch is tested to work correctly (create correctly named and compressed installer files) on both SeaMonkey and Firefox trunk.

Comment 4

[Robert Kaiser]

checked into trunk.

Comment 5

[Luca M.]

Is there a gain in compression?

Comment 6

[Robert Kaiser]

(In reply to comment #5)
> Is there a gain in compression?

Usually there should be, and we saw good gain for normal packages in bug 297914 - surprisingly, I see no difference at the moment for installers...