298055 - Extension/Theme Manager support for DnD and keypress reordering

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

I have DnD and keypress reordering in my tree and was waiting on bug 285584 to
land before submitting a patch. The keypress reordering is done via up/down
arrow along with shift up/down arrow for moving to top and bottom respectively.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 186652 [details] [diff] [review]
patch

I forgot to mention that the patch from bug 285584 removed the indenting I
added for one of the switch statements so this patch adds that back as well as
changes a toBeInstalled attribute that snuck in from Ben's tree to use the
opType attribute.

Comment 3

[Robert Strong (they/them - no direct email)]

Doh! Forgot to say that the keypress reordering uses the control key... I
suspect the code will need to be changed to properly support other platforms
like Macs.

Comment 4

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 270309 has been marked as a duplicate of this bug. ***

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 186652 [details] [diff] [review]
patch

Better patch coming up

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch

This should do it and the keys are
accel+shift+up arrow = move to top
accel+up arrow = move up
accel+down arrow = move down
accel+shift+down arrow = move to bottom

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> *** Bug 270309 has been marked as a duplicate of this bug. ***
This bug will not be adding the move top, move up, and move down menuitems to
the context menu of the theme manager as requested in that bug.

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch

I removed everything not related to this bug out of the patch since I found a
couple of other minor regressions I am going to patch in another bug and
hopefully land that patch quickly.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 186661 [details] [diff] [review]
patch

bit rotted

Comment 10

[Robert Strong (they/them - no direct email)]

We are going to support sorting ascending by name... for anyone that wants this it should be possible with an extension.