298140 - Extension Manager regressions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

There have been a couple of EM regressions with regards to the recent update
landings and one for the richlistbox widget from bug 285584. Patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

-      ctr.InsertElementAt(res, 1, true);
+      ctr.AppendElement(res);
This places items being downloaded for install or being checked for
compatibility at the end of the EM list. Without this when installing a new
item it is first shown at the top of the list and then it is moved to the end
of the list after install which may not be in view.

-    gExtensionsView.selectionForward();
+    gExtensionsView.goDown();
selectionForward was replaced by goDown in the patch for bug 285584.

+   
gExtensionsView.scrollBoxObject.ensureElementIsVisible(gExtensionsView.lastChild);

This is to ensure an item is being downloaded for install or checked for
compatibility is visible in the ui.

The changes in update.js are to get it back to the same functionality it had
before with one exception in that with this patch the "Checking for update to"
status message is updated for each item instead of just the items it has found
an update for.

The changes in errors.xul were missed during the recent update patches and this
gets the error dialog for the extension update wizard working again. Though
additional work on the displaying of errors is being done in bug 245082 I want
to get these regressions fixed before going any farther on that bug.

Comment 2

[Doron Rosenberg (IBM)]

>gExtensionsView.scrollBoxObject.ensureElementIsVisible(gExtensionsView.lastChild);
>
>This is to ensure an item is being downloaded for install or checked for
>compatibility is visible in the ui.

If you want, you could add a ensureElementIsVisible directly to richlistbox.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> If you want, you could add a ensureElementIsVisible directly to richlistbox.
I think that would be a good thing but I think it is best to hold off until
other properties and methods that would provide value to richlistbox are flushed
out... I've been thinking on a couple that would be useful and should have
something within a week or two so it can make it into 1.1.

Comment 4

[Doron Rosenberg (IBM)]

(In reply to comment #3)
> (In reply to comment #2)
> > If you want, you could add a ensureElementIsVisible directly to richlistbox.
> I think that would be a good thing but I think it is best to hold off until
> other properties and methods that would provide value to richlistbox are flushed
> out... I've been thinking on a couple that would be useful and should have
> something within a week or two so it can make it into 1.1.

Sure, will wait with doing a writeup on the widget till that gets settled.

btw, not that I am a toolkit peer, but the patch looks fine.

Comment 5

[Doron Rosenberg (IBM)]

checked in.

Comment 6

[AKIHIRO Misaki (a.k.a Kuden)]

When '.extension-item-name' or '.extension-item-description' are long, the
display is still broken. 
Screen shots
http://maguroban.s41.xrea.com/image/bug_298140_01.png
http://maguroban.s41.xrea.com/image/bug_298140_02.png

Comment 7

[Benjamin Smedberg]

Akihiro, please file a new bug on this issue. Robert, we should probably specify
the width of the left or right pane explicitly, or at least set a min-width.

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> When '.extension-item-name' or '.extension-item-description' are long, the
> display is still broken. 
> Screen shots
> http://maguroban.s41.xrea.com/image/bug_298140_01.png
> http://maguroban.s41.xrea.com/image/bug_298140_02.png
I believe this is due to the Phoenity Modern theme not being updated for the
recent changes... at least the screenshots you provided are from that theme.
With the default theme I don't have this issue with long descriptions, etc. and
a ... is displayed to show the text is cropped as it should. Can you verify this
happens with the default theme?

Comment 9

[Robert Strong (they/them - no direct email)]

Here is a screenshot with the defalt theme that shows it doesn't experience this
problem. Also of note is bug 292617.
http://exchangecode.com/spellbound/themes.png

Comment 10

[AKIHIRO Misaki (a.k.a Kuden)]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050623 Firefox/1.0+
{ID: 2005062314}
New Profile
http://maguroban.s41.xrea.com/image/05062401.png
http://maguroban.s41.xrea.com/image/05062402.png
http://maguroban.s41.xrea.com/image/05062403.png
http://maguroban.s41.xrea.com/image/05062404.png

http://www.catthief.com/mozilla/downloads/mostlycrystal_fx_11.jar
http://count10.hp.infoseek.co.jp/firefox/aya-pinball-fx_0.9.9.3-trunk-rel15.jar

I'm sorry. I do not understand how to do  file a new bug...

Comment 11

[Pardal Freudenthal (:ShareBird)]

(In reply to comment #10)
I can confirm this problem on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b2) Gecko/20050624 Firefox/1.0+ ID:2005062402

http://img205.echo.cx/img205/6729/themesdefault5eb.png

I don't see this on my personal theme:

http://img205.echo.cx/img205/9153/themessilvermel8we.png

I did solve the problem with following code:

#extensionsView[state="themes"] {
-moz-box-flex: 1.5;
width: 10em;
}

at mozapps/extensions/extensions.css

Comment 12

[Robert Strong (they/them - no direct email)]

Opened bug 298699 for the theme manager issue.