298196 - process_bug.cgi updates delta_ts even when no modifications are made

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

The culprits are votes and keywords, see my patch.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Fix two problems:
1) process_bug.cgi has no idea if the "keywords" field has changed or not till
it checks all fields at the end of the process. Thus, delta_ts should not be
updated while this information is unknown.

2) For bugs having no votes, votes = 0 (as expected). But the code incorrectly
set $votes ||= '' which is wrong for this numeric field.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 186766 [details] [diff] [review]
patch, v1

>-            SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp, keywords = " .
>-                    SqlQuote(join(', ', @list)) .
>-                    " WHERE bug_id = $id");
>+            $dbh->do("UPDATE bugs SET keywords = ? WHERE bug_id = ?",
>+                     undef, join(', ', @list), $id);

  OK. So if I only update the keywords, with this patch applied, the delta_ts
is still set correctly? Provided that's the case, thi is r+ on inspection.

>-        $newvalues[$i] ||= '';
>+        $newvalues[$i] = defined($newvalues[$i]) ? $newvalues[$i] : '';

  And yeah, this is obviously correct. It *actually* does what the comment
says, now. :-)

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
>   OK. So if I only update the keywords, with this patch applied, the delta_ts
> is still set correctly?

Yes, but later in the code, where we have checked that keywords have really been
changed.

Comment 4

[Frédéric Buclin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.260; previous revision: 1.259
done