Last Comment Bug 298353 - views need support for context menus on events, and on "blank time"
: views need support for context menus on events, and on "blank time"
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Lightning Only (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Lightning 0.1
Assigned To: Vladimir Vukicevic [:vlad] [:vladv]
:
Mentors:
Depends on:
Blocks: lightning-0.1 298504
  Show dependency treegraph
 
Reported: 2005-06-21 10:16 PDT by Mike Shaver (:shaver -- probably not reading bugmail closely)
Modified: 2006-01-04 07:36 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
calendar-view-context.patch (15.04 KB, patch)
2005-06-21 13:21 PDT, Vladimir Vukicevic [:vlad] [:vladv]
no flags Details | Diff | Splinter Review
calendar-view-context.patch (17.47 KB, patch)
2005-06-21 13:41 PDT, Vladimir Vukicevic [:vlad] [:vladv]
shaver: first‑review+
Details | Diff | Splinter Review
context-menus.patch (12.90 KB, patch)
2005-06-22 11:13 PDT, Vladimir Vukicevic [:vlad] [:vladv]
shaver: first‑review+
Details | Diff | Splinter Review

Description Mike Shaver (:shaver -- probably not reading bugmail closely) 2005-06-21 10:16:16 PDT
 
Comment 1 Vladimir Vukicevic [:vlad] [:vladv] 2005-06-21 13:21:55 PDT
Created attachment 186952 [details] [diff] [review]
calendar-view-context.patch

Note that this patch also includes the patch for the view shrinking.  Patch for
the week view is coming at some point.
Comment 2 Vladimir Vukicevic [:vlad] [:vladv] 2005-06-21 13:34:24 PDT
I've renamed the context attribute to "item-context" instead of "event-context",
for consistency with the month view (which may be able to display todos) and
with any other future views.
Comment 3 Vladimir Vukicevic [:vlad] [:vladv] 2005-06-21 13:41:20 PDT
Created attachment 186953 [details] [diff] [review]
calendar-view-context.patch

month/multiday view patch
Comment 4 Mike Shaver (:shaver -- probably not reading bugmail closely) 2005-06-22 04:31:09 PDT
Comment on attachment 186953 [details] [diff] [review]
calendar-view-context.patch

The calDateTime and messenger-overlay-sidebar changes don't need to be checked
in for this, clearly.  r=shaver on the parts of the patch that are actually
related to this bug (the context-attribute manipulations).
Comment 5 Vladimir Vukicevic [:vlad] [:vladv] 2005-06-22 11:13:09 PDT
Created attachment 187047 [details] [diff] [review]
context-menus.patch

Made "context" work as "item-context" if "item-context" isn't specified.
Comment 6 Mike Shaver (:shaver -- probably not reading bugmail closely) 2005-06-22 12:27:46 PDT
Comment on attachment 187047 [details] [diff] [review]
context-menus.patch

r=shaver, pls take out the test context stuff.
Comment 7 Vladimir Vukicevic [:vlad] [:vladv] 2005-06-22 12:41:52 PDT
checked in

Note You need to log in before you can comment on or make changes to this bug.