298458 - overloading context menu is not working (document.oncontextmenu=newMenu)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P2)

Description

[Josef Doods]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1

If I am overloading the default context menu with my own function, I am getting
both menus the original in foreground and my own in background.
This is working fine with Mozilla, Firefox and Safari and on Windows also with IE.


Reproducible: Always

Actual Results:  
-

Expected Results:  
show only my own context menu

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

L. Perone, is this what you describe in bug 192276 comment 14?

Comment 2

[Josef Doods]

J.Doods, yes this is the same bug. 
> L. Perone, is this what you describe in bug 192276 comment 14?

*** This bug has been marked as a duplicate of 192276 ***

Comment 3

[Simon Fraser [no longer active]]

Not a dup. Bug 192276 is explicitly about plugins.

Comment 4

[L. Perone]

(In reply to comment #1)
> L. Perone, is this what you describe in bug 192276 comment 14?

yes, it is.

I'll repost my testcase url here
http://www.yellowspace.net/camino_tests/cm.html
(control- or right-click on the text "CHAPTER EXAMPLE")

Bug still exists in Camino Version 2005072508 (0.9a2+)

Comment 5

[Simon Fraser [no longer active]]

*** Bug 305921 has been marked as a duplicate of this bug. ***

Comment 6

[Simon Fraser [no longer active]]

This is one of our more serious content issues.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 312714 comment 4.

Comment 8

[Mike Pinkerton (not reading bugmail)]

i don't see us getting this working for 1.0. anyone disagree?

Comment 9

[Simon Fraser [no longer active]]

Camino's context menu handling is a little weird.

When you right-click, the clicked widget's -menuForEvent: method gets called by Cocoa. We fire off an NS_CONTEXTMENU here. As a consequence, the embedding APIs (nsIContextMenuListener) call the app's OnContextMenu listener. However, rather than showing the context menu then, the app code uses it to just save a ref to the clicked DOM node. We unwind back down to the Cocoa widget call, whcih calls up the NSView hierarchy up the app level, where an implementation of -getContextMenu returns the NSMenu that Cocoa needs to be returned from this method.

For embedders, nsDocShellTreeOwner registers a context menu listener. However, its ContextMenu() method always calls PreventDefault() on the event (to fix bug 78396), so context menu events will always have deafult behavior prevented on them (they always return nsEventStatus_eConsumeNoDefault).

If the implementor of the oncontextmenu event in the content calls event.preventDefault(), the embedder's OnContextMenu() is not called, but Camino erroneously goes and returns an NSMenu anyway (likely with the wrong node information). That's what we should fix here.

Comment 10

[Simon Fraser [no longer active]]

Attachment: Testcase

Comment 11

[Simon Fraser [no longer active]]

Attachment: Patch to only show the context menu if we got an OnContextMenu callback.

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 205578 [details] [diff] [review]
Patch to only show the context menu if we got an OnContextMenu callback.

r=pink

Comment 13

[Simon Fraser [no longer active]]

Fixed.

Comment 14

[JK]

I still got no contextual menu in the image of the testcase attachment (latest branch build).

Comment 15

[Simon Fraser [no longer active]]

(In reply to comment #14)
> I still got no contextual menu in the image of the testcase attachment (latest
> branch build).

That is intended behavior in this case. Before the change, you saw the generic page menu (not the image menu).

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass move of mis-filed bugs out of obsolete component; apologies for bugspam.