192276 - "control click" on plugin brings up browser context menu

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect, P2)

Description

[Tracy Walker [:tracy]]

seen with recent chimera builds

-open a page with a flash animation
-control click the animation

tested results: the browser context menu appears

expected results: the flash context menu should appear.

I back tested this and discovered that this regressed between the builds for
2003-01-27-07(works) and 2003-01-28-07(broken since this build)

Comment 1

[Chris Petersen]

Also occurs with embedded QT movies. Tested under 10.1.5 and 10.2.3.

http://www.apple.com/switch/ads/tonyhawk.html

Comment 2

[Chris Petersen]

Same problem with Real content too. No plugin contextual menu when using control
click:

http://www.weather.com/activities/verticalvideo/vdaily/weekendoutlook.html?from=nchomepage

Comment 3

[sairuh (rarely reading bugmail)]

generalizing the summary. could this be a recent regression?

Comment 4

[sairuh (rarely reading bugmail)]

duh, twalker already provides the regression data.

Comment 5

[Simon Fraser [no longer active]]

Taking. Note that a right-click with a two-button mouse works, but a
control-clickk doesn't.

Comment 6

[Simon Fraser [no longer active]]

This may have regressed from pinkerton's change for bug 161832.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/chimera/src/browser&command=DIFF_FRAMESET&file=BrowserWindowController.mm&rev1=1.90.2.61&rev2=1.90.2.62&root=/cvsroot

Comment 7

[Mike Pinkerton (not reading bugmail)]

well, we have no plugin-specific context menu. before my change, we'd show
nothing. now we always show a context menu. i think that's perfectly valid. so
is this bug that we show something at all, or we show the default document
context menu. If it's the latter, I'd vote future.

Comment 8

[Simon Fraser [no longer active]]

You can't tell if you have a plugin-specific context menu. The control-click has
to get down to the plugin, which displays the menu when handling the event.

Comment 9

[Chris Petersen]

*** Bug 158345 has been marked as a duplicate of this bug. ***

Comment 10

[Chris Petersen]

This problem really needs to get fixed since it's affects people with a single
mouse button or a ibook/powerbook user using their trackpad (like me)...

Comment 11

[Ludovic Hirlimann [:Usul]]

still true with 2003090102 on 10.2.6

Comment 12

[Chris Petersen]

Nomimating this issue for 0.8. This is a pain for a powerbook/ibook user
attempting to use the trackpad display the plugin's contextual menu.

Comment 13

[Jasper]

Still true 20040319 NB.

Comment 14

[L. Perone]

I don't know if the following is related to this bug, because it is in a
different context. However, the effect is the same.
Camino draws the browser context menu even when it has been disabled with
JavaScript (for example, to implement my own context menu). 

Here is a test case (control- or right-click on the text "CHAPTER EXAMPLE")
http://www.yellowspace.net/camino_tests/cm.html

Here is a screenshot of what I see:
http://www.yellowspace.net/camino_tests/cm_shot.png

The same page works fine with recent (release 0.8/1.6 and nighties) od FireFox
and Mozilla, Mac and Win alike.

Happens on Camino 2004051308 (v0.8b) and "below".

Comment 15

[Simon Fraser [no longer active]]

Note that right-click works, but control-click doesn't.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also the similar bug 242906 for general misbehavior with CMs on OBJECTs and
EMBEDs.

Comment 17

[Simon Fraser [no longer active]]

Attachment: Patch: return nil from menuForEvent for plugin views

Comment 18

[Josef Doods]

*** Bug 298458 has been marked as a duplicate of this bug. ***

Comment 19

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 190372 [details] [diff] [review]
Patch: return nil from menuForEvent for plugin views

okies. r=pink

Comment 20

[Simon Fraser [no longer active]]

Fixed.