298507 - several uninitialized values used in editwhines.cgi

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

When filling in the subject of a newly-created whining event, an error is
generated in the error_log, presumably because the original subject or body was
never defined.

Reproducible: Always

Steps to Reproduce:
1. Log into Bugzilla tip with an account that can modify its own whines.
2. Access editwhines.cgi
3. Create a new wining event
4. In the empty form that appears, fill in the subject AND NOTHING ELSE

Actual Results:  
The following error was logged in the error.log:

editwhines.cgi: Use of uninitialized value in string ne at
/Library/WebServer/Documents/bugzilla-new/editwhines.cgi line 150.

Expected Results:  
I expected to see zero errors generated when loading the page.

This is using the version of editwhines.cgi from tip.

Comment 1

[A. Karl Kornel]

Attachment: Patch v1

I was actually off by one.  It wasn't $subject or $body that was failing, it
was $events->{$eventid}->{'subject'} and $events->{$eventid}->{'body'}.

It seems that when a new whining event is created (lines 88-95), NULL is used
as the default values for subject and body, which makes the subject/body in the
hash undefined.

I guess this is the most basic solution.  Before the comparison around line
150, the hash is checked and any undef values are reaplaced with an empty
string.

Comment 2

[Frédéric Buclin]

Comment on attachment 188080 [details] [diff] [review]
Patch v1

>+                $events->{$eventid}->{'subject'} |= '';
>+                $events->{$eventid}->{'body'} |= '';

The right fix is to modify get_events(), assuming we don't want to store empty
strings into the 'whine_events' table:

$events->{$ev} = {
    'subject' => $sub || '',
    'body' => $bod || '',
};

Comment 3

[Frédéric Buclin]

*** Bug 298509 has been marked as a duplicate of this bug. ***

Comment 4

[A. Karl Kornel]

Attachment: Patch v2

modifies attachment 188080 [details] [diff] [review] with respect to comment 2

Comment 5

[Frédéric Buclin]

Comment on attachment 188119 [details] [diff] [review]
Patch v2

r=LpSolit

Comment 6

[Frédéric Buclin]

Note that there is still a potential undefined value at line 194 due to:
if ($cgi->param("mailto_type_$sid") == MAILTO_USER)

I still don't understand how $cgi->param("mailto_type_$sid") could be undefined.

Comment 7

[Frédéric Buclin]

Checking in editwhines.cgi;
/cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v  <--  editwhines.cgi
new revision: 1.7; previous revision: 1.6
done