298509 - Numeric comparison on uninitialized value in editwines.cgi

Status: RESOLVED DUPLICATE of bug 298507

(Bugzilla :: Whining, defect)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

In editwhines.cgi (the tip version), the following appears on line 194:

> if ($cgi->param("mailto_type_$sid") == MAILTO_USER) {

This results in an uninitialized value warning if "mailto_type_$sid" is not
defined.  Specifically, it generated the folloeing in error_log:

editwhines.cgi: Use of uninitialized value in numeric eq (==) at
/Library/WebServer/Documents/bugzilla-new/editwhines.cgi line 194.

Reproducible: Sometimes

Steps to Reproduce:




So far, this has only happened on my first attempt to create a whine.  It has
not appeared since then.

Comment 1

[A.K.K (old account, not used anymore)]

Attachment: Checks for defined-ness before doing comparison

Modifies the 'if' to first check that the variable is defined before going onto
the numeric comparison.

This assumes that the bug is actually real, and not invalid.

Comment 2

[A.K.K (old account, not used anymore)]

Comment on attachment 187060 [details] [diff] [review]
Checks for defined-ness before doing comparison

This was accidentally submitted using an old account.  Removing review pending
updated submission from my real account.

Comment 3

[Frédéric Buclin]

please fix that in bug 298507. It's meaningless to open a new bug for each
warning you get in error_log when related to the same file.


*** This bug has been marked as a duplicate of 298507 ***