298553 - Document shell service changes (bug 274374)

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Asaf Romano (gone)]

* Set default browser, set as desktop... and mail integration are now exposed
on mac (But, on mac, the menu item doesn't mention new messages, etc).
 * "Set as wallpaper" was renamed to "Set as desktop backgorund".

Comment 1

[Jeff Walden (gone starting June 8)]

To save readers a little time checking source, the renaming to "Set As Desktop
Background" applies on all platforms, not just on Macs (exactly why, I don't know).

Comment 2

[Steffen Wilberg]

Attachment: patch

This stuff is exposed on Linux/Gnome as well, although Send Link/Read Mail/New
Message/Set as Desktop Background don't work here. But that might be my system.

Comment 3

[Adam Guthrie]

Attachment: corrected spelling error

backgorund > background.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 188101 [details] [diff] [review]
patch

>+ You can choose various display
>+  &pref.plural; through the dialog that is shown.</p>

Please don't expose this part on mac.

Comment 5

[Steffen Wilberg]

Comment on attachment 188103 [details] [diff] [review]
corrected spelling error

Thanks Adam, but no need for a new patch.

Comment 6

[Steffen Wilberg]

Attachment: patch v1.1

Fixes the above comments, and removes another "only on Windows and Linux"
sentence.

Comment 7

[Jeff Walden (gone starting June 8)]

Comment on attachment 188106 [details] [diff] [review]
patch v1.1

>+  click the mouse button</span> on an image and choose <em>Set as desktop
>+  background</em> from the popup menu.

That should be "Set As Desktop Background..." (note caps/ellipsis).

>+  <span class="noMac">You can choose various display &pref.plural; through the
>+  dialog that is shown.</span></p>

I don't know why Mano is (so adamantly?) opposed to displaying the last
sentence on Macs.  That said, is there a reason we need to even mention the
extra choices anywhere?  The presented choices are fairly mundane, and I don't
see a reason to mention the dialog.  If the user's reading through Help and
sees this, he's only going to use it if he means to use it.  If he accidentally
uses it, he'll find out about the extra dialog at that time.  Mentioning it
here adds nothing in terms of extra safety.

So, r=me if you're okay with removing this sentence.  If you're not, explain
why and we'll go from there.

Comment 8

[Steffen Wilberg]

Comment on attachment 188106 [details] [diff] [review]
patch v1.1

I agree with removing the sentence completely.

Mano was against displaying it on Mac because these options are #ifndef
XP_MACOSX:
http://lxr.mozilla.org/seamonkey/source/browser/components/shell/content/setDes
ktopBackground.xul#74

Comment 9

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml,v  <-- 
menu_reference.xhtml
new revision: 1.29; previous revision: 1.28
done
Checking in mozilla/browser/locales/en-US/chrome/help/prefs.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/prefs.xhtml,v  <--  prefs.xhtml
new revision: 1.32; previous revision: 1.31
done
Checking in mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml,v  <-- 
using_firebird.xhtml
new revision: 1.27; previous revision: 1.26
done