Closed Bug 298555 Opened 19 years ago Closed 19 years ago

"Set as desktop background" does not work

Categories

(Firefox :: Menus, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: plutot, Assigned: asaf)

References

Details

(Whiteboard: [cb] landed for 1.8b3)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622 Firefox/1.0+

ight clicking on an image to "set as desktop background" is sort of broken - the
dialog does come up but when you press OK it does nothing. 

Reproducible: Always

Steps to Reproduce:
1. Right-click on ANY image on ANY web site
2. Select "Set as desktop background"
3. Press OK

Actual Results:  
Nothing happens

Expected Results:  
The desktop background should change.
->New
what is the regressiondate ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
First noticed it in this build
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622
Firefox/1.0+ ID:2005062220

Its been a few days since I used that menu so I'm not sure if its related to bug
298478
This is very likely regression from bug 274374.
Depends on: 274374
Assignee: nobody → bugs.mano
Priority: -- → P1
Target Milestone: --- → Firefox1.1
Status: NEW → ASSIGNED
Also note that this was kind of broken before, see bug 297286 (an older regression)
Attached patch fixSplinter Review
doh!
Attachment #187127 - Flags: review?(mconnor)
Attachment #187127 - Flags: approval-aviary1.1a2?
Flags: blocking1.8b3?
Flags: blocking1.8b3? → blocking1.8b3+
Attachment #187127 - Flags: review?(mconnor) → review+
Attachment #187127 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Checking in browser/components/shell/content/setDesktopBackground.js;
/cvsroot/mozilla/browser/components/shell/content/setDesktopBackground.js,v  <--
 setDesktopBackground.js
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
mconnor broke the mac case in bug bug 292737

http://tinyurl.com/74pb5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
OS: Windows XP → All
Hardware: PC → All
Attached patch patchSplinter Review
Mike, that's a regression from bug 292737 (you've added a call to makeURI w/o
adding the relevant script).
Attachment #187204 - Flags: review?(mconnor)
Attachment #187204 - Flags: approval-aviary1.1a2?
Status: REOPENED → ASSIGNED
Attachment #187204 - Flags: review?(mconnor) → review+
Attachment #187204 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Checking in setDesktopBackground.xul;
/cvsroot/mozilla/browser/components/shell/content/setDesktopBackground.xul,v 
<--  setDesktopBackground.xul
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Whiteboard: [cb] ready to land for 1.8b3?
Whiteboard: [cb] ready to land for 1.8b3? → [cb] landed for 1.8b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: