298555 - "Set as desktop background" does not work

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[plutot]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622 Firefox/1.0+

ight clicking on an image to "set as desktop background" is sort of broken - the
dialog does come up but when you press OK it does nothing. 

Reproducible: Always

Steps to Reproduce:
1. Right-click on ANY image on ANY web site
2. Select "Set as desktop background"
3. Press OK

Actual Results:  
Nothing happens

Expected Results:  
The desktop background should change.

Comment 1

[Peter van der Woude [:Peter6]]

->New
what is the regressiondate ?

Comment 2

[Peter van der Woude [:Peter6]]

related to Bug 298478 ?

Comment 3

[plutot]

First noticed it in this build
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050622
Firefox/1.0+ ID:2005062220

Its been a few days since I used that menu so I'm not sure if its related to bug
298478

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is very likely regression from bug 274374.

Comment 5

[José Jeria]

Also note that this was kind of broken before, see bug 297286 (an older regression)

Comment 6

[Asaf Romano (gone)]

Attachment: fix

doh!

Comment 7

[Asaf Romano (gone)]

Checking in browser/components/shell/content/setDesktopBackground.js;
/cvsroot/mozilla/browser/components/shell/content/setDesktopBackground.js,v  <--
 setDesktopBackground.js
new revision: 1.2; previous revision: 1.1
done

Comment 8

[Asaf Romano (gone)]

mconnor broke the mac case in bug bug 292737

http://tinyurl.com/74pb5

Comment 9

[Asaf Romano (gone)]

Attachment: patch

Mike, that's a regression from bug 292737 (you've added a call to makeURI w/o
adding the relevant script).

Comment 10

[Asaf Romano (gone)]

Checking in setDesktopBackground.xul;
/cvsroot/mozilla/browser/components/shell/content/setDesktopBackground.xul,v 
<--  setDesktopBackground.xul
new revision: 1.2; previous revision: 1.1
done