298658 - When Enter key is pressed in FAYT mode, we should close find toolbar

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When Enter key is pressed in FAYT mode, we should close find toolbar.
Because, if enter key is pressed in FAYT mode (including Ctrl + Enter and Shift
+ Enter), the FAYT mode is eneded. So the toolbar is not needed.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

nsITypeAheadFind.idl's update is my mistake too.
In bug 259454, I changed the interfase, bug I forgot to change GUID.

Comment 2

[Asaf Romano (gone)]

> if enter key is pressed in FAYT mode, the FAYT mode is ended.

not for me, why is this change needed?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I changed FAYT behavior by bug 259454.

In that change, FAYT mode is ended when the find toolbar lost focus actualy.
Because if the focus is set the found link (so the find toolbar doesn't have
focus), we cannot handle IME transaction by Javascript code. So, if CJK users
are using IME in FAYT mode and press Ctrl + Enter, they may be confused that the
FAYT mode is continuing. (But actualy, they cannot use IME for FAYT)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 187189 [details] [diff] [review]
Patch rv1.0

I will recreate new patch.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 187189 [details] [diff] [review]
Patch rv1.0

Sorry, this patch is right.
Please check this.

Comment 6

[Asaf Romano (gone)]

(In reply to comment #3)
> I changed FAYT behavior by bug 259454.
> 
> In that change, FAYT mode is ended when the find toolbar lost focus actualy.

err? the find toolbar isn't (and shoedn't be) focused when FAYT is used, have
you changed that?

(Going to test it myself anyway.)

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #6)

> err? the find toolbar isn't (and shoedn't be) focused when FAYT is used, have
> you changed that?

Currently, the find toolbar has focus in FAYT mode.
The found link having "pseudo" focus only. Actual focus is set on the input
field of find toolbar.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

CJK users are confused by this problem.
Please block the release.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 187189 [details] [diff] [review]
Patch rv1.0

Thank you Bryan.

Its risk is very low.
This bug may confuse users.

Comment 10

[Asa Dotzler [:asa]]

Mike, is this something we want? 

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 12

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b3) Gecko/20050713
Firefox/1.0+ ID:2005071314

This now works (pressing enter or return IF what the user searched for is
found.) However, if the text the user has searched for is a link, and they press
return to get rid of the find bar, the link found containing the searched-for
text is then opened. Is this expected behaviour?

1. Go to http://forums.mozillazine.org/viewtopic.php?t=291588
2. Pop the find bar with /
3. Search for 178
4. Notice that '178' is found in the line "1. #178120 [Firefox]-Chevron box not
updated when renamed bookmarks exceed/under-run the Bookmark Toolbar [All]"
5. Press return to close the findbar

Expected (?)
- Find bar is closed.

Actual
- Find bar is closed, and bug 178120 is loaded.

I'm not exactly sure if the link should be navigated to, but I thought I'd
document what I see in case it's not meant to work like that.

Comment 13

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b3) Gecko/20050713
Firefox/1.0+ ID:2005071314
Actually, does this work?
If you pop the find bar on this page, and search for 'press' it finds text, but
on pressing enter or return, the find bar remains.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> Expected (?)
> - Find bar is closed.
> 
> Actual
> - Find bar is closed, and bug 178120 is loaded.

No, I designed "Find bar is closed, and bug 178120 is loaded".
If you pressed Enter when an link element has pseudo-focus, the Enter key
pressed event is fired the link element and after it, the Find bar is closed.

Comment 15

[:deanis74]

So Enter will no longer work for Find Again, is that right?

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #15)
> So Enter will no longer work for Find Again, is that right?

Enter working for Find Again is only normal find mode(Ctrl + F) only.
In FAYT mode, Enter is not working for Find Again.

Comment 17

[:deanis74]

(In reply to comment #16)
> Enter working for Find Again is only normal find mode(Ctrl + F) only.
> In FAYT mode, Enter is not working for Find Again.

Correct you are.  I shouldn't read bugs early in the morning.

Comment 18

[John Lewis]

When FAYT mode is set for links only, then ENTER should open that link.  It's
the obvious reason for having a links only FAYT and was being used by many we
applications to speed data entry.  We have missed this functionality since 9 and
have not upgraded our clients since then.  Please allow this functionality again
as our users miss it and we would like to stay with a current version.

Comment 19

[Mike Connor [:mconnor]]

John, if you invoke FAYT in links only mode (i.e. pressing ') then Enter does
indeed act like this, just not when invoked with Ctrl-F, which has never behaved
like that.

Comment 20

[John Lewis]

(In reply to comment #19)
> John, if you invoke FAYT in links only mode (i.e. pressing ') then Enter does
> indeed act like this, just not when invoked with Ctrl-F, which has never behaved
> like that.

You are right.  Sorry.  We've been praying for the return of this feature for
several revisions.  Thanks guys, you all rock.