178120 - Chevron box not updated when renamed bookmarks exceed/under-run the Bookmark Toolbar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jeff Griffiths]

I use the bookmark toolbar a lot, and was abbreviating link labels to make more
room. i noticed that even though i made the labels short enough for all links to
be visible, the hidden links did not become visible until the window was resized
- against normal expectations but hardly critical.

perhaps the link editing event isn't refreshing the bookmark toolbar / perhaps
it should...

Comment 1

[David P James]

What do you mean by "hidden links"? I could understand what you were saying
until then.

Comment 2

[Jeff Griffiths]

by 'hidden' i mean this:

you have ten links in the bookmark toolbar

the phoenix window is sized such that only eight of those links are visible ie
it isn't wide enough to show all ten, hence there are 2 'hidden' links available
using a little menu thingy on the extreme right. 

Comment 3

[André Dahlqvist]

Confirmed on Linux. The Chevron should dissapear when you make enough room for
the overlapping bookmarks on the toolbar. Bug 177266 could be a little related.

Comment 4

[Asa Dotzler [:asa]]

Also closely related to bug 173493, possibly a dupe. We're not updating the
things until a window resize and we should update when anything that impacts
spacing changes. 

Comment 5

[Jesse Ruderman]

I've seen this too.  Renaming a bookmark on the toolbar does not cause Phoenix
to recalculate whether there should be a chevron, but deleting or adding a
bookmark does.

Comment 6

[djk]

Attachment: resize the bookmark toolbar when a bookmark name changes

Comment 7

[djk]

another pch review request...

Comment 8

[Erik]

*** Bug 204837 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Ross]

Pierre, can you take a look at this patch?  If it's good we'll take it for 1.0,
otherwise it's not critical.

Comment 10

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040120
Firebird/0.8.0+

Is the bug still fixed?

Comment 12

[Simon Paquet [:sipaq]]

I'm still seeing this. I will bug pch on IRC when I see him the next time.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Simon, i tried several OS with a current build and a new profile. It's still
working for me.

Comment 14

[Andreas Kunz]

Henrik, I still see this with a recent CVS build:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040207
Firebird/0.8.0+ (no extensions, new profile). Note that this is about renaming
bookmarks in the PT.

Comment 15

[Asa Dotzler [:asa]]

*** Bug 236629 has been marked as a duplicate of this bug. ***

Comment 16

[Neil Paris]

*** Bug 266378 has been marked as a duplicate of this bug. ***

Comment 17

[Owen Jones]

I see this behaviour. I bookmarked this page into the bookmark toolbars folder
as many times as needed until there were too many too be shown at once, then
renamed some of them to just "b". The bookmark that had been shunted off the
side of the bookmarks toolbar folder did not reappear, and the chevron was still
there, until I resized the window.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.6) Gecko/20050321
Firefox/1.0.2

Comment 18

[Gregor Rosenauer]

*** Bug 297679 has been marked as a duplicate of this bug. ***

Comment 19

[zug_treno]

Reproducible with Mozilla 1.8b1 and Mozilla 1.8b2/20050613. It seems that the
opposite also happens. If you rename a bookmark in the Personal Toolbar and give
it a name that's too long, the >> only appears after a resize (could be Suite
bug 206769?).

Comment 20

[José Jeria]

Is the patch still valid?

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, I missunderstand this bug in former times. I can still reproduce it with
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050621
Firefox/1.0+

Updating summary for easier understanding what's not working.

I don't think that the patch will work due to the long cycle time. We should
update it.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Updated patch to resize PTB

We can't check aSource to be the BookmarkToolbarFolder. Instead aSource is the
bookmark, which was changed, itself. Also LastModifiedState is in the namespace
"rdf:http://home.netscape.com/WEB-rdf#".

Comment 23

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 188840 [details] [diff] [review]
Updated patch to resize PTB

r=vladimir

Comment 24

[Asaf Romano (gone)]

Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.47; previous revision: 1.46
done

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with CVS build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3)
Gecko/20050713 Firefox/1.0+

Comment 26

[Wayne Mery (:wsmwk)]

Comment on attachment 118678 [details] [diff] [review]
resize the bookmark toolbar when a bookmark name changes

obsolete