298943 - if bookmarks.html is missing , bookmark.bak is not copied to bookmarks.html

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Peter van der Woude [:Peter6]]

for backup of bookmarks , bookmark.bak was created.
however, the file is overwritten by the default bookmarks.html at startup

WARNING : backup your bookmarks before you try to reproduce !

repro:
1. close all FF instances
2. go to profile
3. delete bookmarks.html (NOT bookmarks.bak !)
4. open Firefox
5. open bookmarks and notice that all your bookmarks are replaced by the default
set.

exp:
in case that only bookmarks.html is missing, but bookmarks.bak is present
Firefox should copy bookmarks.bak to bookmarks.html to prevent dataloss

Comment 1

[Peter van der Woude [:Peter6]]

I forgot to mention the worst part.
if a new bookmarks.html is created from default , bookmarks.bak is immediately
overwritten and so all bookmarks are lost

Comment 2

[Mike Connor [:mconnor]]

This is evil, and if we fix this, I think we're past 99% of dataloss bugs at the
least.  Still looking, ccing some people who'll have an interest.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If this isn't working, then there's something wrong with
nsBookmarksService::MaybeRestoreFromBackup -- it should (is, but sounds like
it's buggy) explicitly be checking for both non-existant bookmarks.html and for
0-size bookmarks.html.

Comment 4

[Benjamin Smedberg]

I probably caused this bug while fixing another, in
nsBrowserDirectoryProvider.cpp it uses EnsureProfileFile() unconditionally. I
did this so that if bookmarks.html is missing it is copied from the default
profile, which happens in the cases where you create a profile using the PM UI
or with the -profile commandline flag.

Comment 5

[John Collins]

(In reply to comment #4)
> I probably caused this bug while fixing another, in
> nsBrowserDirectoryProvider.cpp it uses EnsureProfileFile() unconditionally. I
> did this so that if bookmarks.html is missing it is copied from the default
> profile, which happens in the cases where you create a profile using the PM UI
> or with the -profile commandline flag.

I can say that this bug has existed for at least 5-6 weeks...I think I may still
have the nightly from when i remember this...If i find it, ill update you all...

Comment 6

[Chris Beard]

benjamin, would you be able to fix this?  if not, who should we get to do it?

/cb

Comment 7

[Benjamin Smedberg]

Attachment: Move bookmarks.html restoration backup/profile logic, rev. 1

Comment 8

[[e-mail]]

Comment on attachment 190865 [details] [diff] [review]
Move bookmarks.html restoration backup/profile logic, rev. 1

Although I don't understand why it's the job of the profile service to install
the default bookmarks.

Comment 9

[Chase Phillips]

Comment on attachment 190865 [details] [diff] [review]
Move bookmarks.html restoration backup/profile logic, rev. 1

a=[e-mail]

Comment 10

[Benjamin Smedberg]

Fixed on trunk for 1.8b4