Closed
Bug 299182
Opened 20 years ago
Closed 20 years ago
consider removing .isAllDay from calIEvent
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mvl, Assigned: pavlov)
Details
Attachments
(2 files)
|
6.27 KB,
patch
|
vlad
:
first-review+
|
Details | Diff | Splinter Review |
|
16.71 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
isAllDay is the same as startDate.isDate. If one is set, the other should be set
too. We should remove .isAllDay, to make the implementation simpler. The callers
need to be updated, but most already use .isDate, since .isAllDay is mostly broken.
|
||
Comment 1•20 years ago
|
||
So let's say we all agree -- who wants to bake the bread?
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•20 years ago
|
||
Assignee: shaver → pavlov
Attachment #187883 -
Flags: first-review?(vladimir)
Comment on attachment 187883 [details] [diff] [review]
remove isAllDay
r=pillsbury
Attachment #187883 -
Flags: first-review?(vladimir) → first-review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
checked in. there are probably a few other spots in sunbird that need to be
updated as well for this api change... mvl can you take a look? I don't have a
current sunbird tree.
|
Reporter | |
Comment 5•20 years ago
|
||
This patch updates sunbird. I think i got all callers.
Attachment #188569 -
Flags: first-review?(vladimir)
|
||
Comment 6•20 years ago
|
||
Comment on attachment 188569 [details] [diff] [review]
update sunbird callers
Not stepping on your toes vlad, mvl asked for review in IRC and I need this for
bug 286070.
Attachment #188569 -
Flags: first-review?(vladimir) → first-review+
|
|
Reporter | |
Comment 7•20 years ago
|
||
sunbird is updated. marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•