299182 - consider removing .isAllDay from calIEvent

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

isAllDay is the same as startDate.isDate. If one is set, the other should be set
too. We should remove .isAllDay, to make the implementation simpler. The callers
need to be updated, but most already use .isDate, since .isAllDay is mostly broken.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

So let's say we all agree -- who wants to bake the bread?

Comment 2

[Stuart Parmenter]

Attachment: remove isAllDay

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 187883 [details] [diff] [review]
remove isAllDay

r=pillsbury

Comment 4

[Stuart Parmenter]

checked in.  there are probably a few other spots in sunbird that need to be
updated as well for this api change...  mvl can you take a look?  I don't have a
current sunbird tree.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: update sunbird callers

This patch updates sunbird. I think i got all callers.

Comment 6

[Joey Minta]

Comment on attachment 188569 [details] [diff] [review]
update sunbird callers

Not stepping on your toes vlad, mvl asked for review in IRC and I need this for
bug 286070.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

sunbird is updated. marking fixed.