299273 - xforms-select and xforms-deselect events not firing for selects

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Stephen Pride]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4

The xforms-select and xforms-deselect events are not firing.

Reproducible: Always

Comment 1

[Stephen Pride]

Attachment: testcase

Comment 2

[Stephen Pride]

Attachment: testcase

Correct testcase - previous one had wrong xforms namespace prefix.

Comment 3

[Allan Beaufour]

Yes, select's do not dispatch these yet. For select1 this depends on bug 281668.

Should we XBL'ize select too, or implement the support in the current code?

Comment 4

[Doron Rosenberg (IBM)]

Attachment: le patch

Comment 5

[Doron Rosenberg (IBM)]

Not sure where to put this in the select1 code

Comment 6

[aaronr]

Comment on attachment 199847 [details] [diff] [review]
le patch

check out the testcase I'm about to attach.  Assuming I'm right, your patch
doesn't process it right.  I believe that in @incremental="false", we should
still do the xforms-select and xforms-deselect and not wait for the blur. 
Also, this doesn't seem to be remembering the initial selection state.	If an
item is pre-selected and then I deselect it, no event.

Comment 7

[aaronr]

Attachment: aaron's testcase

Comment 8

[aaronr]

Attachment: aaron's testcase II

added an input element to make sure that changing the value via another control
gave the right event sequence.	Sent a note off to Novell to see if my testcase
is right, but I think it is.

Comment 9

[Doron Rosenberg (IBM)]

Attachment: fixes non-incremental select

Note that the testcase is "invalid" - alerts cause an alert, which will steal
focus and cause the value-changed of the select to happen.

Comment 10

[aaronr]

Comment on attachment 199965 [details] [diff] [review]
fixes non-incremental select

>Index: extensions/xforms/resources/content/select.xml
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/xforms/resources/content/select.xml,v
>retrieving revision 1.3
>diff -w -u -1 -0 -r1.3 select.xml
>--- extensions/xforms/resources/content/select.xml	5 Oct 2005 16:17:48 -0000	1.3
>+++ extensions/xforms/resources/content/select.xml	18 Oct 2005 19:25:27 -0000
                options[i].control.QueryInterface(Components.interfaces.nsIXFormsSelectChild).value;
>+
>+              // if it wasn't selected before add to the list of newly selected items
>+              if (!options[i].wasSelected) {
>+                newSelectedControls.push(options[i].control);
>+              }
>+
>+              options[i].wasSelected = true;
>+            } else {
>+              // it was selected before, but now unselected
>+              if (options[i].wasSelected) {
>+                this.dispatchSelectEvent(options[i].control, "xforms-deselect")
>             }
>+
>+              options[i].wasSelected = false;
>+            }
>+          }

nit: Please fix curly braces alignment problem.

Comment 11

[aaronr]

(In reply to comment #10)
> (From update of attachment 199965 [details] [diff] [review] [edit])
> >Index: extensions/xforms/resources/content/select.xml
> >===================================================================
> >RCS file: /cvsroot/mozilla/extensions/xforms/resources/content/select.xml,v
> >retrieving revision 1.3
> >diff -w -u -1 -0 -r1.3 select.xml
> >--- extensions/xforms/resources/content/select.xml	5 Oct 2005 16:17:48 -0000	1.3
> >+++ extensions/xforms/resources/content/select.xml	18 Oct 2005 19:25:27 -0000
>                
> options[i].control.QueryInterface(Components.interfaces.nsIXFormsSelectChild).value;
> >+
> >+              // if it wasn't selected before add to the list of newly selected items
> >+              if (!options[i].wasSelected) {
> >+                newSelectedControls.push(options[i].control);
> >+              }
> >+
> >+              options[i].wasSelected = true;
> >+            } else {
> >+              // it was selected before, but now unselected
> >+              if (options[i].wasSelected) {
> >+                this.dispatchSelectEvent(options[i].control, "xforms-deselect")
> >             }
> >+
> >+              options[i].wasSelected = false;
> >+            }
> >+          }
> 
> nit: Please fix curly braces alignment problem.
> 


Also be nice if you could figure out a way to keep dispatchSelectEvent common between select and select1.

Comment 12

[Doron Rosenberg (IBM)]

Attachment: select1 patch

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 199965 [details] [diff] [review]
fixes non-incremental select

Same comments what Aaron had. Though, not sure what to do with dispatchSelectEvent.

Comment 14

[Doron Rosenberg (IBM)]

checked into trunk

Comment 15

[aaronr]

needs to stay open until it is on the branch

Comment 16

[gabe]

its not goona be in 1.8 branch

Comment 17

[gabe]

probly wont be anymore checkins for branch

Comment 18

[aaronr]

checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0

Comment 19

[aaronr]

verfied fixed on MOZILLA_1_8_BRANCH