299379 - DOMFocusIn/DOMFocusOut not working properly

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Stephen Pride]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4

The DOMFocusIn and DOMFocusOut events should be caught when a value is changed
for a form control that traps for them, but it doesn't.  See testcase.

Reproducible: Always

Comment 1

[Stephen Pride]

Attachment: testcase

Comment 2

[Allan Beaufour]

Actually, the 1.0 errata removes the mention of the DOM focus events:
http://www.w3.org/MarkUp/Forms/Group/Drafts/Sources/errata.html#E70e

Comment 3

[Allan Beaufour]

OK. I missed something. It's not removed, it's just not specified in the value
change sequence. They should still be dispatched...

Comment 4

[aaronr]

Well, the right way to do this is to support DOMFocusIn and DOMFocusOut in the
core, which bryner says they will definitely take, but I'm sure it will be too
late for FF 1.5.  We could dispatch it ourselves as a stop gap until then, though.

Comment 5

[Doron Rosenberg (IBM)]

Attachment: le patch

Comment 6

[Doron Rosenberg (IBM)]

Attachment: le patch

Comment 7

[Doron Rosenberg (IBM)]

Comment on attachment 199973 [details] [diff] [review]
le patch

double submit somehow, removing

Comment 8

[aaronr]

Comment on attachment 199974 [details] [diff] [review]
le patch

So far so good.  But looking at the spec looks like DOMFocusIn/Out needs to
happen for: input, secret, textarea, output, upload, trigger, range, submit,
select, select1, and group.  I don't know what we should do for output or
group, but the rest seem straight forward.

Comment 9

[Doron Rosenberg (IBM)]

Attachment: better patch

For a full appearance select, this is hard to implement, so XXX: for now.

Comment 10

[Doron Rosenberg (IBM)]

Attachment: even better patch

Comment 11

[aaronr]

Comment on attachment 200143 [details] [diff] [review]
even better patch

Looks good.  Please open a bug for range and upload to support these (or leave
this bug open to account for them).

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 200143 [details] [diff] [review]
even better patch

I guess this is ok for now.

Comment 13

[Doron Rosenberg (IBM)]

Checked into trunk. Do we want this on branch?

Comment 14

[alexander :surkov (:asurkov)]

Since bug 275453 was fixed then patch should be updated. Now 'upload' element calls removed dispatchDOMActivate() method.

Comment 15

[Doron Rosenberg (IBM)]

checked into branch.