Closed Bug 299622 Opened 19 years ago Closed 18 years ago
Di: Pressing End in a blank line moves the caret back, to the end of the previous line
To reproduce: 1. Open the attached testcase 2. Put the caret between the two characters (in the beginning of the empty line). 3. Press End Actual result: The caret moves back, to the end of the previous line Expected result: The caret should always stay in the same line when End is pressed, in this case it should remain where it is (as the line is without text) The same problem happens in the LTR textarea, but not if the page is still treated by Gecko as non-BiDi (another testcase is coming). I'm marking the Severity of this bug as 'Minor', because in real life there isn't any point in pressing End in an empty line. Nevertheless, this bug can be useful to learn more about the otherwise buggy caret behavior in BiDi texts. Prog.
This happens to be fixed by my patch to bug 16311. It has little to do with most of the other BiDi caret bugs, as nsTextFrame::PeekOffset() is never entered in this case.
Depends on: 16311
Ignore comment #3. It's no longer true after fixing the various regressions from my original patch to bug 16311.
No longer depends on: 16311
I'm not sure what the original intention of this code was, but at least following the fix to bug 16311 and the subsequent fixes to bug 305239, PeekOffset(), in the case of HOME and END, only reverses the hint if it has a good reason to do so. Ignoring this reversing is what led to this bug.
As usual, forgot to remove some unrelated stuff from the patch before submitting. Trying again.
Comment on attachment 193559 [details] [diff] [review] patch IIRC that code was intended to handle the case where the first frame on the line was in a different direction from the paragraph direction, but in the current code base that case also works much better with your patch. r=me
Attachment #193559 - Flags: review?(smontagu) → review+
Comment on attachment 193559 [details] [diff] [review] patch ROC - this is a bit of code removal which makes things look neater and work better. Don't worry - I won't ask for this to go into the branch :-)
Attachment #193559 - Flags: superreview?(roc)
Attachment #193559 - Flags: superreview?(roc) → superreview+
Patch checked in to trunk by mrbkap at 2005-08-24 10:46.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #193559 - Flags: approval1.8.1? → branch-1.8.1?(roc)
Attachment #193559 - Flags: approval-branch-1.8.1?(roc) → approval-branch-1.8.1+
Checked in to 1.8.1 branch: Checking in mozilla/layout/generic/nsSelection.cpp; /cvsroot/mozilla/layout/generic/nsSelection.cpp,v <-- nsSelection.cpp new revision: 22.214.171.124; previous revision: 126.96.36.199 done
Target Milestone: mozilla1.9alpha → mozilla1.8.1
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.