299758 - [l10n] "Add to Address Book" not localized.

Status: RESOLVED FIXED

(Camino Graveyard :: Translations, defect)

Description

[Markus Amalthea Magnuson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1

It seems like the context meny choice "Add to Address Book" (on mailto-links)
isn't localized, even though I've translated it. When I check that CM in
Interface Builder it is translated, but not when I run Camino.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Any reason this is not confirmed?  Is this just another string missing?

Comment 2

[Wevah (Nate Weaver)]

It looks like the item title is set in code, via a string in Localized.strings
(though I'm not sure why, if it's in a nib).

Does adding

"Add to Address Book" = "Your localized string";

to your language's Localized.strings file work?

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Markus, does Wevah's suggestion work?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> It looks like the item title is set in code, via a string in Localized.strings
> (though I'm not sure why, if it's in a nib).

Wevah, is it done that way because it switches to "Open %@ in Address Book" when
clicking on the address of someone already in your Address Book (note that
string is present in Localized.strings)?

Comment 5

[Wevah (Nate Weaver)]

That's probably why.

Comment 6

[Marcello Testi]

Confirmed Wevah's expectations. Adding the string to Localizable.strings solves
the problem.
Ex. 
/* mailto: link menu options */
"Open %@ in Address Book" = "Apri %@ in Rubrica Indirizzi";
"Add to Address Book" = "Aggiungi a Rubrica Indirizzi";

Can somebody check-in an updated Localizable.strings?

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Updated localizable.strings for checkin

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mike/Simon, here's an updated Localizable.strings file for checkin to fix this.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 197241 [details]
Updated localizable.strings for checkin

Reminder that this is waiting for checkin :-)

Comment 10

[Simon Fraser [no longer active]]

Checked in, trunk and branch.