Alarm pop-up only shows once

RESOLVED FIXED

Status

Calendar
Lightning Only
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Joey Minta, Assigned: Joey Minta)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
I'm only getting lightning's alarm window to pop-up once per session.

Steps to Reproduce:
1.) Set 2 alarms, 1 minute apart
2.) When the first alarm fires, close the alarm window.
3.) Wait for the second alarm.

Actual Results:
2nd alarm window never shows.

It seems !gAlarmWindow is false the second time the alarm observer is called.
(Assignee)

Comment 1

12 years ago
Created attachment 188758 [details] [diff] [review]
patch v1

This is one option for fixing the problem, I'm sure there are others.
(Assignee)

Updated

12 years ago
Attachment #188758 - Flags: first-review?(pavlov)
(Assignee)

Comment 2

12 years ago
Comment on attachment 188758 [details] [diff] [review]
patch v1

dmose, do you want to take a look at this?  I think pavlov is a bit busy with other things.
Attachment #188758 - Flags: first-review?(pavlov) → first-review?(dmose)
(Assignee)

Comment 3

12 years ago
Comment on attachment 188758 [details] [diff] [review]
patch v1

We decided this might expose security holes in firefox-lightning.  cancelling review-request.
Attachment #188758 - Flags: first-review?(dmose)

Updated

12 years ago
Blocks: 298366

Updated

12 years ago
Assignee: shaver → nobody

Updated

12 years ago
QA Contact: shaver → lightning

Updated

12 years ago
Depends on: 323678
(Assignee)

Comment 4

12 years ago
Created attachment 208934 [details] [diff] [review]
use getMostRecentWindow

Uses getMostRecentWindow.  Given bug 323678 comment #2, this seems like the best way to go.  Tested with all the different scenarios (alarm window open/closed, alarm window previously closed/not previously closed) and alarms fired as expected in each.
Assignee: nobody → jminta
Attachment #188758 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #208934 - Flags: first-review?(dmose)

Comment 5

12 years ago
Comment on attachment 208934 [details] [diff] [review]
use getMostRecentWindow

r=dmose
Attachment #208934 - Flags: first-review?(dmose) → first-review+

Updated

12 years ago
No longer depends on: 323678
(Assignee)

Comment 6

12 years ago
patch checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.