Closed Bug 299847 Opened 19 years ago Closed 19 years ago

Alarm pop-up only shows once

Categories

(Calendar :: Lightning Only, defect)

Product:
Calendar
Component:
Lightning Only
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

References

Details

Attachments

(1 file, 1 obsolete file)

use getMostRecentWindow
2.22 KB, patch
dmosedale
: first-review+
Details | Diff | Splinter Review 
I'm only getting lightning's alarm window to pop-up once per session.

Steps to Reproduce:
1.) Set 2 alarms, 1 minute apart
2.) When the first alarm fires, close the alarm window.
3.) Wait for the second alarm.

Actual Results:
2nd alarm window never shows.

It seems !gAlarmWindow is false the second time the alarm observer is called.
Attached patch patch v1 (obsolete) — — Splinter Review 
This is one option for fixing the problem, I'm sure there are others.
Attachment #188758 - Flags: first-review?(pavlov)
Comment on attachment 188758 [details] [diff] [review]
patch v1

dmose, do you want to take a look at this?  I think pavlov is a bit busy with other things.
Attachment #188758 - Flags: first-review?(pavlov) → first-review?(dmose)
Comment on attachment 188758 [details] [diff] [review]
patch v1

We decided this might expose security holes in firefox-lightning.  cancelling review-request.
Attachment #188758 - Flags: first-review?(dmose)
Assignee: shaver → nobody
QA Contact: shaver → lightning
Attached patch use getMostRecentWindow — — Splinter Review 
Uses getMostRecentWindow.  Given bug 323678 comment #2, this seems like the best way to go.  Tested with all the different scenarios (alarm window open/closed, alarm window previously closed/not previously closed) and alarms fired as expected in each.
Assignee: nobody → jminta
Attachment #188758 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #208934 - Flags: first-review?(dmose)
Comment on attachment 208934 [details] [diff] [review]
use getMostRecentWindow

r=dmose
Attachment #208934 - Flags: first-review?(dmose) → first-review+
No longer depends on: 323678
patch checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: