Closed Bug 299847 Opened 15 years ago Closed 14 years ago
Alarm pop-up only shows once
I'm only getting lightning's alarm window to pop-up once per session. Steps to Reproduce: 1.) Set 2 alarms, 1 minute apart 2.) When the first alarm fires, close the alarm window. 3.) Wait for the second alarm. Actual Results: 2nd alarm window never shows. It seems !gAlarmWindow is false the second time the alarm observer is called.
This is one option for fixing the problem, I'm sure there are others.
Comment on attachment 188758 [details] [diff] [review] patch v1 dmose, do you want to take a look at this? I think pavlov is a bit busy with other things.
Attachment #188758 - Flags: first-review?(pavlov) → first-review?(dmose)
Comment on attachment 188758 [details] [diff] [review] patch v1 We decided this might expose security holes in firefox-lightning. cancelling review-request.
Attachment #188758 - Flags: first-review?(dmose)
Uses getMostRecentWindow. Given bug 323678 comment #2, this seems like the best way to go. Tested with all the different scenarios (alarm window open/closed, alarm window previously closed/not previously closed) and alarms fired as expected in each.
Comment on attachment 208934 [details] [diff] [review] use getMostRecentWindow r=dmose
Attachment #208934 - Flags: first-review?(dmose) → first-review+
patch checked in
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.