299916 - CVS Account request for Gavin Sharp <[e-mail]>

Status: VERIFIED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[:Gavin Sharp [email: [e-mail]]]

I'm requesting a CVS account for Firefox and Toolkit related code. Mike Connor
said he would vouch.

I'll attach my public SSH key and will try to get the form faxed/mailed some
time in the next week.

Comment 1

[Mike Connor [:mconnor]]

I'll definitely vouch for Gavin, he's been doing a lot of good work on the
Firefox front end.  

Bugs he's already fixed, and I have a handful more waiting on reviews and/or
checkins.

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&emailassigned_to1=1&emailtype1=exact&email1=gavin.sharp%40gmail.com&chfieldto=Now

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: SSH Public key

Here is my public key. I've just sent the CVS Contributor form by fax.

Is there anything else needed here?

Comment 3

[Marcia Knous [:marcia]]

form received. need some SRs to post in the bug in order to get write access. I
would suggest adding them to the cc list.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Thanks Marcia.

I'm asking for access to Firefox and Toolkit code only, which don't require SR,
so I was under the impression that the three SR requirement is waived.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

After talking with Mike Connor, I figured it wouldn't hurt to ask for some SRs
to look over my work. I'm CCing Boris and Darin, who have looked at some of my
patches before, as well as Brendan to round out the group. My work has pretty
much been restricted to front-end, Firefox and Toolkit code, which is why I
didn't think of asking for the SR review. If they don't feel comfortable "SRing"
my request, that's absolutely fine, I figured there is no harm in asking :).

I guess my issue here is that the current policy for account requests doesn't
explicitly address contributors to non-core code. I know in the past that CVS
accounts have been granted while relying on the honor-system to limit checkins
to certain areas, and I certainly wouldn't mind if that's what needed to happen
here.

Comment 6

[Boris Zbarsky [:bzbarsky]]

sr=bzbarsky.

Gavin, in general people check in where they check in.  There's really no
substantive difference between the sort of code you've been working on and any
other code in the codebase (unlike, say, the difference between help content and
most of the codebase; those sort of cases are where the honor-system setup you
mention has been used).  There's no reason you shouldn't check in non-UI patches
(for other people as needed, or for yourself when you finally decide that you
really want to be working on Gecko instead ;) ).

Comment 7

[Darin Fisher]

I also vouch for Gavin.  He does good work.  sr=darin

Comment 8

[Daniel Veditz [:dveditz]]

sr=dveditz

Comment 9

[Marcia Knous [:marcia]]

Account created. Over to justdave for SSH key.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Shaver installed the SSH key, I've tested the account and it works, so this is
fixed. Thanks to all!