300527 - Cannot create composition window

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect)

Description

[David A. Cobb]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050710 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050710 Firefox/1.0+ THUNDERBIRD 2005-07-10-05-Trunk

All actions requiring a message composition window: Write, Reply, or Edit-as-New
result in a modal "Error Trying to Create Message Compositon Window"

Attachment comming

Reproducible: Always

Steps to Reproduce:

Comment 1

[David A. Cobb]

Attachment: Screenshot of Thunderbird showing ErrorBox

Comment 2

[John Benes]

Confirmed

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712
Thunderbird/1.0+ ID:2005071214

->PC/All?

Comment 3

[Scott MacGregor]

this appears to be a problem with .zip builds only and that's not something we
officially support so this isn't an alpha 2 blocker.

Comment 4

[Žiga Sancin]

It's actually present in the tarballs (win and linux; see screenshot)...

Comment 5

[Scott MacGregor]

bisi, if you look inside your linux package at the chrome directory
(thunderbird\chrome) you should see files like classic.jar, etc.

Do you have a file in that location called app-chrome.manifest?

I think that file is missing on at least the windows .zip builds.

Comment 6

[Scott MacGregor]

Attachment: fix for windows ZIP builds

this won't fix the linux tarball but it does fix the problem for windows .zip
builds.

Comment 7

[David A. Cobb]

re: comment#5
Scott, my thunderbird/chrome contains the following *.manifest files

classic.manifest
comm.manifest
en-US.manifest
messenger.manifest
newsblog.manifest
offline.manifest
pippki.manifest
toolkit.manifest

No app-chrome.* anything!

For Linux, "zip" builds is all we have!
Mine, FWIW, is Debian kernel 2-6-11, mostly 'sarge' some 'sid'

Comment 8

[Scott MacGregor]

Attachment: app-chrome.manifest file

can one of you try dropping this file into your chrome directory (same
directory that classic.jar is in) and tell me if it fixes it for you?

Comment 9

[Scott MacGregor]

cc'ing bsmedberg as we've been having an e-mail conversation about this. 

Benjamin it sounds like my suggested patch to fix the windows .zip builds is
incorrect and I should packaged installed-chrome.txt instead of app-chrome.manifest.

That just leaves us with the problem on linux tarball which does have an
installed-chrome.txt that looks correct, so I'm not sure why that's not finding
the editor locale yet. 

Comment 10

[Benjamin Smedberg]

Do we still need those wallet locale files? I was under the impression we did
not. Possible patch for editor upcoming.

Comment 11

[Benjamin Smedberg]

Attachment: The correct fix, rev. 1

This is the "correct" fix for editor, I don't know if that's what you want to
do with the release bits or not. Hand-adding app-chrome.manifest to the release
bits does not sound like a really awful hack, if we don't want to respin.

Comment 12

[Scott MacGregor]

Comment on attachment 189133 [details] [diff] [review]
The correct fix, rev. 1

I'll talk to chase about what's easiest for the linux alpha 2 candidate.

thanks for the patch Benjamin.

Comment 13

[Scott MacGregor]

David/Bisi, can you guys try dropping in the app-chrome.manifest file that I
posted here in your chrome directory and tell me if that fixes the problem? I
need to know so I can try to repackage the alpha 2 bits with this file before we
put it up on the ftp site. Thanks!

Comment 14

[Žiga Sancin]

Sorry Scott, I went to bed yesterday (it was already 2am local time for me)...
I'm not a regular linux user, so I couldn't verify, if the file
app-chrome.manifest was missing. Today I've installed ubuntu and tried the
latest trunk build (20050713). Thunderbird is working normally when clicking on
"write" (and the app-chrome.manifest file is where it should be), so there was a
problem on older trunk builds or on David's computer.

Sorry for the confusion, let's get the Alpha 2 out (and I'm booting back to
windows)! ;)

Comment 15

[Scott MacGregor]

Thanks Bisi. The problem is we already have the alpha 2 bits so we can't use
bits from 7/13. So I'm trying to figure out if I have to add
app-cheomre.manifest to the linux build found here:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2005-07-12-05-trunk/thunderbird-1.0+.en-US.linux-i686.tar.gz

Maybe I should be asking to see if more folks had this problem with the 7/12
bits on Linux...

Comment 16

[Scott MacGregor]

Also, Benjamin hasn't checked in the fix yet, that's interesting that today's
7/13 linux build didn't demonstrate the problem at all for you.

Comment 17

[John Benes]

Scott, dropping the app-chrome.mainfest file in the chrome directory fixes the
windows ZIP builds for me. Used build ID:2005071214

Comment 18

[Žiga Sancin]

Hum, I'll check the build Scott... wait a few minutes (I'm still on linux :)).

Comment 19

[Žiga Sancin]

I'm not seeing this bug with the above build.

Comment 20

[Benjamin Smedberg]

Scott, the linux build you linked to has an installed-chrome.txt; as long as it
is run from a location where the user has write access it should be fine
(unzipping it as root and then running it as an unprivileged user won't work,
but that's not a new problem).

Comment 21

[Scott MacGregor]

Comment on attachment 189133 [details] [diff] [review]
The correct fix, rev. 1

Benjamin, do we need to do something similar for wallet? I notied the app
manifest file is registering both editor and wallet chrome.

Comment 22

[Ashley Bischoff (blog at handcoding.com)]

Seeing this on Win2k (20050712 with a zip build). OS -> All.

Comment 23

[Benjamin Smedberg]

If we still need the wallet locale files... which I don't think we do.

Comment 24

[Scott MacGregor]

I've checked in Benjamin's patch (thank you!).

Comment 25

[Mike Cowperthwaite]

*** Bug 300986 has been marked as a duplicate of this bug. ***

Comment 26

[David A. Cobb]

RE: comment#8 comment#13: Sorry it took so long to see this!

I put the 2-line version in <install-dir>/chrome
yes it works!

Debian-Linux