300721 - italicized bogus characters lead to gap and overlapping text

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect, P3)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b3) Gecko/20050713
Firefox/1.0+

Steps to reproduce:
1. Load the testcase.

Result: There is a gap in Michael's name where there should be a question mark,
and his name overlaps with the date.

Bug 138883 might be related.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Uri Bernstein]

How is this different than bug 138883?

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think this is the same bug as bug 138883, but a lot cleaner :-)

I can repro bug 138883 by forcing encoding to UTF-8 (Camino returns the slashdot
page in that bug as ISO-8859-1), whereas this testcase specifies UTF-8 on an
ISO-8859-1 page so no fiddling is required.

Comment 4

[Simon Fraser [no longer active]]

So this only shows up when the page is using an incorrect glyph for the page
encoding?

Comment 5

[Jesse Ruderman]

Smokey, I noticed this bug when I loaded a Bugzilla bug report and Firefox
incorrectly treated it as UTF-8.  To make the testcase reproducable, I made the
testcase specify that the encoding is UTF-8.

Simon, what else should I test?  Characters from an obscure language that Mac OS
X doesn't include fonts for?

Comment 6

[Jesse Ruderman]

*** Bug 138883 has been marked as a duplicate of this bug. ***

Comment 7

[Simon Fraser [no longer active]]

Attachment: Patch: remove use of NS_SUCCEEDED on PRBool return values

This patch also contains some formatting cleanup, and the addition of |const|
on a couple of small static data tables.

Comment 8

[Simon Fraser [no longer active]]

The gaps in the text resulting in an x offset of the length of the text already
drawn, because of the incorrect logic.

Comment 9

[jhp (no longer active)]

Comment on attachment 189630 [details] [diff] [review]
Patch: remove use of NS_SUCCEEDED on PRBool return values

Ha!  That's quite humorous.  Good find.

Comment 10

[Simon Fraser [no longer active]]

Checked in.