Closed Bug 300759 Opened 19 years ago Closed 19 years ago

Bad sorting when showing languages and special characters are used

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: knocte, Assigned: jshin1987)

Details

(Keywords: intl)

Attachments

(2 files, 1 obsolete file)

Screenshot that demonstrates the bug
42.33 KB, image/gif
Details
update
1.40 KB, patch
mconnor
: review+
mconnor
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8b3) Gecko/20050712 Firefox/1.0+

When sorting languages alphabetically, Firefox shows:

A
B
C
D
E
R
S
Á
É

Expected results should be:

A
Á
B
C
D
E
É
R
S

I am attaching a screenshot that demonstrates the bug.

Reproducible: Always

Steps to Reproduce:
An example of this behaviour (because I suppose it is a bug in a general purpose
sorting routine) can be found here: "Tools" menu -> "Advanced" tab -> "General"
tab -> "Languages" frame, "Edit languages" button, "Select a language to add" combo.

  

  



    
    

    
  
Bugzilla has had a problem to show the special characters used in my first
comment. To clarify things, I will encode them in HTML:

Results:

a
b
c
d
e
r
s
á�
é

Expected results:

a
á�
b
c
d
e
é
r
s

  

  



    
    

    
  
Related to Suite bug 142864?

  

  



    
  
Assignee: nobody → jshin1987
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All

    
  
Status: NEW → ASSIGNED
Component: General → Preferences
Keywords: intl

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  

  

  



    
    

    
  
Comment on attachment 189510 [details] [diff] [review]
patch


>-                                        if (a.name < b.name) return -1;
>-                                        if (a.name > b.name) return 1;
>-                                        return 0;
>+                                        return a[0].localeCompare(b[0]);

The above line should read

  return a.name.localeCompare(b.name);

  

  



    
    

    
  

      
      
      
      

        Attached patch
          
          
        update
        — 
          — Splinter Review
      

    


  
this is a trivial fix (porting what's done in bug 142864 for suite  to firefox)

  

  



        Attachment #189510 -
        Attachment is obsolete: true

        Attachment #189882 -
        Flags: review?(mconnor)

        Attachment #189882 -
        Flags: review?(mconnor)

        Attachment #189882 -
        Flags: review+

        Attachment #189882 -
        Flags: approval1.8b4+

    
    

    
  
was this checked in / fixed ?

  

  



    
    

    
  
sorry i forgot to mark this as fixed. fix was checked in on July 20th. 

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: