300759 - Bad sorting when showing languages and special characters are used

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Andrés G. Aragoneses]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8b3) Gecko/20050712 Firefox/1.0+

When sorting languages alphabetically, Firefox shows:

A
B
C
D
E
R
S
Á
É

Expected results should be:

A
Á
B
C
D
E
É
R
S

I am attaching a screenshot that demonstrates the bug.

Reproducible: Always

Steps to Reproduce:
An example of this behaviour (because I suppose it is a bug in a general purpose
sorting routine) can be found here: "Tools" menu -> "Advanced" tab -> "General"
tab -> "Languages" frame, "Edit languages" button, "Select a language to add" combo.

Comment 1

[Andrés G. Aragoneses]

Attachment: Screenshot that demonstrates the bug

Comment 2

[Andrés G. Aragoneses]

Bugzilla has had a problem to show the special characters used in my first
comment. To clarify things, I will encode them in HTML:

Results:

a
b
c
d
e
r
s
á�
é

Expected results:

a
á�
b
c
d
e
é
r
s

Comment 3

[zug_treno]

Related to Suite bug 142864?

Comment 4

[Jungshik Shin]

Attachment: patch

Comment 5

[Jungshik Shin]

Comment on attachment 189510 [details] [diff] [review]
patch


>-                                        if (a.name < b.name) return -1;
>-                                        if (a.name > b.name) return 1;
>-                                        return 0;
>+                                        return a[0].localeCompare(b[0]);

The above line should read

  return a.name.localeCompare(b.name);

Comment 6

[Jungshik Shin]

Attachment: update

this is a trivial fix (porting what's done in bug 142864 for suite  to firefox)

Comment 7

[Peter van der Woude [:Peter6]]

was this checked in / fixed ?

Comment 8

[Jungshik Shin]

sorry i forgot to mark this as fixed. fix was checked in on July 20th.