Closed Bug 301253 Opened 18 years ago Closed 18 years ago

Support application uninstaller

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8final

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Keywords: fixed1.8, Whiteboard: [software update] [1.8 Branch ETA 8/5])

Attachments

(2 files, 1 obsolete file)

test script that converts update.log to install wizard format
3.06 KB, text/plain
Details
v1.1 patch
12.80 KB, patch
bugs
: review+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review 
Support application uninstaller

Several things need to change:

 1-  When a patch is applied, we need to record a changelist in the format
     expected by UninstallFirefox.exe.  This means writing an install_wizardN.log
     file in the uninstall subdirectory.

 2-  Include UninstallFirefox.exe in the MAR file so that we are always running
     the proper version of the uninstaller.
Blocks: 290390
Status: NEW → ASSIGNED
Flags: blocking-aviary1.1?
Target Milestone: --- → Firefox1.1
Need this for b4
Flags: blocking-aviary1.1? → blocking1.8b4+
Whiteboard: [software update]
Whiteboard: [software update] → [software update] [1.8 Branch ETA 8/5]
This is just some JS code that I whipped up to test converting update.log to
the install wizard format that the uninstaller knows how to read.  I still need
to add code to write out registry key information.  Once that's complete, I'll
be able to test that the uninstaller knows how to process the generated log,
and then I can just add this code to nsPostUpdateWin.js.
Attached patch v1 patch (obsolete) — — Splinter Review 
Initial patch.	I still need to finish testing this before it will be ready to
land.  And, this does nothing about ensuring that we include the latest
uninstaller bits in the MAR file.
OK, this mostly works.  The uninstaller appears to still leave a few directories
and files hanging around, so a bit more tweaking is probably in order.
There's a bug in the v1 patch.  The directory list is not properly sorted, which
causes some directories to not be deleted.  New patch coming up...
Attached patch v1.1 patch — — Splinter Review 

        Attachment #191732 -
        Attachment is obsolete: true

        Attachment #192028 -
        Flags: review?(bugs)

        Attachment #192028 -
        Flags: review?(bugs) → review+

    
  

        Attachment #192028 -
        Flags: approval1.8b4?

    
  
Blocks: branching1.8

    
  

        Attachment #192028 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Blocks: 310873

    
  
Keywords: fixed1.8
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.