310873 - Auto-update across versions with different app version does not update uninstall info

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Rishi Maharaj]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1

When updating from Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5)
Gecko/20050930 Firefox/1.4 to Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b5) Gecko/20051001 Firefox/1.4.1, uninstall information is not updated.
This  makes it impossible to uninstall via Add/Remove Programs. An "Uninstall
log not found" error is given when trying to uninstall, and the Add/Remove
Programs entry still refers to 'Mozilla Firefox (1.4)'. Additionally, on running
a 1.4.1-branded installer, a new entry is created - for 'Mozilla Firefox
(1.4.1)', instead of updating the existing entry.

Reproducible: Always

Steps to Reproduce:
1. Install the 20050930 branch nightly.
2. Auto-update to the 20051001 nightly.
3. Try to uninstall via Add/Remove Programs.

Actual Results:  
"Log not found" error.

Expected Results:  
Firefox is uninstalled.

Comment 1

[Peter van der Woude [:Peter6]]

Confirmed

Comment 2

[Ria Klaassen (not reading all bugmail)]

WFM. Installed 30-9 nightly. Updated it with Help > Check for updates. It
updated it to 1-10 and I had no problem to uninstall in the Software window.
(Do you want to uninstall Firefox 1.4 and all of its components...?)
After uninstalling the directory was empty.

Comment 3

[IU]

Note:  I too experienced this bug, but only after Software Update first failed
to successfully apply a partial update then switched to and successfully
installed a complete update.

Thus, if I'm not mistaken, this bug show up only if Software Update installs a
complete build.

Comment 4

[Asa Dotzler [:asa]]

Darin, can you look into this? I think we probably need to make it better by Final.

Comment 5

[Darin Fisher]

I just checked the registry on my machine where Firefox was updated from 1.4 to
1.4.1, and it appears to have the same problem.  The registry settings are not
correct :-(

Comment 6

[Darin Fisher]

OK, the problem here is that the directory service query for XREExeF is failing.
 I think that what's going on here is that one of my patches for toolkit/xre
didn't make it into the tree :-(

Comment 7

[Darin Fisher]

Attachment: v1 patch

In fact, this is the patch I wrote for bug 301253.  Unfortunately, I completely
forgot to include it in the patch that I uploaded to that bug, and as a result
it never made it into the tree.  The patch is very simple.  It just provides a
directory service key that returns the same thing as the XRE_GetBinaryPath
function.

Comment 8

[Darin Fisher]

fixed-on-trunk

Comment 9

[Scott MacGregor]

we're gonna respin the beta 2 bits once this fix lands. 

Comment 10

[Darin Fisher]

fixed1.8