Auto-update across versions with different app version does not update uninstall info

RESOLVED FIXED in mozilla1.8final

Status

()

Toolkit
Application Update
--
major
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Rishi Maharaj, Assigned: Darin Fisher)

Tracking

({fixed1.8, regression})

1.8.0 Branch
mozilla1.8final
x86
Windows XP
fixed1.8, regression
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.70 KB, patch
Benjamin Smedberg
: review+
Mike Schroepfer
: approval1.8b5+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1

When updating from Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5)
Gecko/20050930 Firefox/1.4 to Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b5) Gecko/20051001 Firefox/1.4.1, uninstall information is not updated.
This  makes it impossible to uninstall via Add/Remove Programs. An "Uninstall
log not found" error is given when trying to uninstall, and the Add/Remove
Programs entry still refers to 'Mozilla Firefox (1.4)'. Additionally, on running
a 1.4.1-branded installer, a new entry is created - for 'Mozilla Firefox
(1.4.1)', instead of updating the existing entry.

Reproducible: Always

Steps to Reproduce:
1. Install the 20050930 branch nightly.
2. Auto-update to the 20051001 nightly.
3. Try to uninstall via Add/Remove Programs.

Actual Results:  
"Log not found" error.

Expected Results:  
Firefox is uninstalled.
(Reporter)

Updated

13 years ago
Version: unspecified → 1.5 Branch
Confirmed
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Flags: blocking1.8b5?
WFM. Installed 30-9 nightly. Updated it with Help > Check for updates. It
updated it to 1-10 and I had no problem to uninstall in the Software window.
(Do you want to uninstall Firefox 1.4 and all of its components...?)
After uninstalling the directory was empty.

Comment 3

13 years ago
Note:  I too experienced this bug, but only after Software Update first failed
to successfully apply a partial update then switched to and successfully
installed a complete update.

Thus, if I'm not mistaken, this bug show up only if Software Update installs a
complete build.

Comment 4

13 years ago
Darin, can you look into this? I think we probably need to make it better by Final.
Assignee: nobody → darin
Flags: blocking1.8b5? → blocking1.8b5+
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.5
(Assignee)

Comment 5

13 years ago
I just checked the registry on my machine where Firefox was updated from 1.4 to
1.4.1, and it appears to have the same problem.  The registry settings are not
correct :-(
(Assignee)

Comment 6

13 years ago
OK, the problem here is that the directory service query for XREExeF is failing.
 I think that what's going on here is that one of my patches for toolkit/xre
didn't make it into the tree :-(
(Assignee)

Updated

13 years ago
Depends on: 301253
(Assignee)

Comment 7

13 years ago
Created attachment 198468 [details] [diff] [review]
v1 patch

In fact, this is the patch I wrote for bug 301253.  Unfortunately, I completely
forgot to include it in the patch that I uploaded to that bug, and as a result
it never made it into the tree.  The patch is very simple.  It just provides a
directory service key that returns the same thing as the XRE_GetBinaryPath
function.
Attachment #198468 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #198468 - Flags: review?(benjamin) → review+
(Assignee)

Updated

13 years ago
Attachment #198468 - Flags: approval1.8b5?
(Assignee)

Comment 8

13 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Attachment #198468 - Flags: approval1.8b5? → approval1.8b5+

Comment 9

13 years ago
we're gonna respin the beta 2 bits once this fix lands. 
(Assignee)

Comment 10

13 years ago
fixed1.8
Keywords: fixed1.8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.