301283 - Toolbar customize gives js error after removing searchbar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Martijn Wargers (dead)]

See also discussion here:
http://forums.mozillazine.org/viewtopic.php?t=293935&start=15&sid=aa28ca0442836f7726db03ef1ccbc994#1614988

To reproduce:
- Open the customize window 
- Drag the searchbar into this window
- Click on Done -> error appears:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://browser/content/search.xml ::  :: line 74"  data: no]

Now, every time you open the customize window again and click on 'Done', you get
the same error again.

This doesn't happen in 20050707 build, but it happens in 20050708 build.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is the controller just not there anymore after the first time?

More interestingly, if you customize toolbars to have and then not have the
searchbar, does the searchbar work?

Comment 2

[Asa Dotzler [:asa]]

Does anything actually break here?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

No, nothing breaks, but it may be the cause of memory leaks, and it clutters the
console. This whole situation kind of sucks, but it doesn't really suck any more
than it has on the branch, so this probably shouldn't be considered a blocker.
I'll attach a patch to get rid of the warning.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: Coverup exception

Comment 5

[Myzar]

(In reply to comment #2)
> Does anything actually break here?

well something breaks, the paste and go extension stops working after that error
msg in the js console until the browser is restarted.

for stops working i mean the paste & go line disappears in ff right click
context menu

Comment 6

[Asa Dotzler [:asa]]

please land this on the trunk and when it's verified there we'll revevaluate for
branch. thanks.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checked in on trunk. This patch is trivial, it just masks the exception, so the
risk that it effects anything but the JS Console error is close to zero.

Checking in search.xml;
/cvsroot/mozilla/browser/base/content/search.xml,v  <--  search.xml
new revision: 1.26; previous revision: 1.25
done

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 Branch.
mozilla/browser/base/content/search.xml; new revision: 1.25.2.1;

Comment 9

[Myzar]

(In reply to comment #8)
> Checked in on the 1.8 Branch.
> mozilla/browser/base/content/search.xml; new revision: 1.25.2.1;

Sorry for bugspam but it's not really fixed, you just hide the exception but
paste & go extension still breaks :)

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b4) Gecko/20050830
Firefox/1.0+ ID:2005083006

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> Sorry for bugspam but it's not really fixed, you just hide the exception but
> paste & go extension still breaks :)

If you think a bug marked fixed isn't fixed, that's not bugspam :). The reason
that "Paste and Go" is broken doesn't have anything to do with this bug, though,
it's broken because of bug 306358.