301311 - Default Font : select object height is too small to display font selection

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Tracy Walker [:tracy]]

seen on Deer Park Linux build 2005-07-19-05-trunk

-Go to Preferences | Content | Fonts & Colors
notice size the Default Font: Select object

Tested results:  The height of the object is too small to display the current
text selection. (Although the object is clickable and fonts can be selected from
the list.)

expected results: The height of the Default Font select object should be the
same as the Size : select object just to the right.

Comment 1

[Asaf Romano (gone)]

Screenshot?

Comment 2

[Tracy Walker [:tracy]]

Attachment: small select object in Linux Pref Content panel

Comment 3

[Adam Guthrie]

*** Bug 301821 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Connor [:mconnor]]

ok, we're missing a fallback case here where if the pref value doesn't match
something in the list, we hork, so we need to pick something if the pref value
doesn't match (using the same method we do to fall back sanely in content).

Comment 5

[Mike Connor [:mconnor]]

ok, so nsIFontEnumerator.getDefaultFont is basically useless (even though its
used in chrome, which I haven't bothered to track down yet) so I need an idea of
how to pick a sane default font.

jshin, is there a sane way of getting the appropriate default font based on
langgroup and font type that I can use here?  I can fix this in about 12 seconds
once I have that.

Comment 6

[Mike Connor [:mconnor]]

Ok, so the options are:

a) try to replicate the means to pick the fallback font, and select that
b) create a blank menuitem and select that

a) is going to be hard from JS since GetDefaultFont is not implemented.  The
fallback to b) seems likely, this is 98% cosmetic.

Comment 7

[Mike Connor [:mconnor]]

Attachment: fixes the visual glitch by inserting a blank menuitem and selecting it

If we weren't in l10n freeze, we could add a label such as "No font selected"
or somesuch, but I'm not convinced that's valuable in general, and certainly
not worth late-l10n for.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 192802 [details] [diff] [review]
fixes the visual glitch by inserting a blank menuitem and selecting it

r=me