Image-related items in context menu do not appear when images are disabled or for broken images.

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
13 years ago
5 months ago

People

(Reporter: Matt Nordhoff (aka Peng on IRC & forums), Assigned: neil@parkwaycc.co.uk)

Tracking

({fixed1.7.13, regression})

Trunk
fixed1.7.13, regression
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [can be fixed for firefox] (regression from 293527))

Attachments

(1 attachment, 1 obsolete attachment)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050719 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050719 Firefox/1.0+

If I go to a page with a broken image on it and right-click on the image, the
image-related context menu items (View Image, Copy Image Location, etc.) don't
appear, as they should. They do appear perfectly fine for images that are
working, though.


Also, just to say, I've never submitted a bug before, so please don't hurt me if
I did it all wrong or something.

Reproducible: Always

Steps to Reproduce:
1. Go to a page with a broken image.
2. Right-click on it.
Actual Results:  
The context menu appeared, but it did not have the image-related items.

Expected Results:  
The context menu should have appeared with the image-related items.

Tested with default theme and no extensions, in recent (within the last week,
maybe) Linux trunk nightlies.
(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4)
Gecko/20050719 Firefox/1.0+
> Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4)
Gecko/20050719 Firefox/1.0+
> 
> If I go to a page with a broken image on it and right-click on the image, the
> image-related context menu items (View Image, Copy Image Location, etc.) don't
> appear, as they should. They do appear perfectly fine for images that are
> working, though.
> 
> 
> Also, just to say, I've never submitted a bug before, so please don't hurt me if
> I did it all wrong or something.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Go to a page with a broken image.
> 2. Right-click on it.
> Actual Results:  
> The context menu appeared, but it did not have the image-related items.
> 
> Expected Results:  
> The context menu should have appeared with the image-related items.
> 
> Tested with default theme and no extensions, in recent (within the last week,
> maybe) Linux trunk nightlies.

Oh, actually, it looks like there was one extension in my blank profile, but
still, I doubt it or the extensions I have in my main profile are related to the
issue.

Also, if the dead image is also a link, you can click on Properties in the
context menu and it will show the stuff related to the image there...
(Reporter)

Updated

13 years ago
Version: unspecified → Trunk

Comment 2

13 years ago
Confirming, this also applies when browsing with images disabled, it is no
longer possible to view a particular image by right-clicking it and selecting
View Image.

Regression Window:
Works: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050713 Firefox/1.0+
Fails: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050714 Firefox/1.0+

The items appear again after reverting the changes from Top Secret Bug 293527.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Linux → All
Hardware: PC → All
Summary: Image-related items in context do not appear for broken images. → Image-related items in context menu do not appear when images are disabled or for broken images.

Comment 3

13 years ago
Since I can't comment in Bug 293527 I'm CCing the people from its checkin
comment, I hope that's OK, apologies if it's not.
Flags: blocking1.8b4?
maybe that should've only disabled save, not all image-related menu items...
So... This raises the question of what options should be available on what
images.  Should "view image" be available on a broken image?  I don't think so.
 But it should be available on a blocked image...

What we need here is a UI spec (neil?  mconnor?).  Then
nsIImageLoadingContent.imageBlockingStatus and status of the primary request can
be used to implement said UI spec.

Not a core bug, so not a 1.8b4 issue.  But Seamonkey may need similar changes,
of course.
Flags: blocking-aviary1.5?

Comment 6

13 years ago
is this the same as bug 299881
So, the reason the stuff isn't available is that weird stuff in the <img src="">
can pose a security risk, and bug 293527 is about that? Huh. Well, it looks like
Properties is still available (I could swear I didn't see it before), which
would mean I could still view a broken image, though it would be a bit less
convenient. WONTFIX, maybe?
This shouldn't be wontfix.  I should be able to "view image" on a blocked image
to view it, for example.
Right. Forgot that the bug had been expanded to cover blocked images, too. Yes,
you should be able to view them. It doesn't even look like the item to unblock
images from that server is available. That's not right. Also, why isn't there
some sort of icon for blocked images?
"view them" as in "right-click on them and hit View Image", of course. :-)

Updated

13 years ago
Flags: blocking1.8b4? → blocking1.8b4+

Updated

13 years ago
Assignee: nobody → mconnor
Whiteboard: [can be fixed for firefox]
(Assignee)

Comment 12

13 years ago
Created attachment 190638 [details] [diff] [review]
Patch v0.1a
Attachment #190638 - Flags: review?(mconnor)
So... Should an <input type="text"> (which is instanceof nsIImageLoadingContent)
really give image context menu options?  I think you want instanceof
nsIImageLoadingContent and a non-null uri...
Comment on attachment 190638 [details] [diff] [review]
Patch v0.1a

>@@ -3973,7 +3974,7 @@ nsContextMenu.prototype = {
>         if (shell)
>           haveSetDesktopBackground = true;
> #endif
>-        this.showItem( "context-setDesktopBackground", haveSetDesktopBackground && this.onImage );
>+        this.showItem( "context-setDesktopBackground", haveSetDesktopBackground && this.onLoadedImage );
> 
>         if ( haveSetDesktopBackground && this.onImage ) {

this should change to onLoadedImage too, otherwise looks good.	Thanks!
Attachment #190638 - Flags: review?(mconnor) → review+
(Assignee)

Comment 15

13 years ago
Created attachment 190707 [details] [diff] [review]
Patch v0.1b

Addressed mconnor, biesi and bz's comments.
Attachment #190638 - Attachment is obsolete: true
Attachment #190707 - Flags: superreview?(bzbarsky)
Attachment #190707 - Flags: review+
Attachment #190707 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Comment 16

13 years ago
Comment on attachment 190707 [details] [diff] [review]
Patch v0.1b

regression fix
Attachment #190707 - Flags: approval1.8b4?

Updated

13 years ago
Assignee: mconnor → neil.parkwaycc.co.uk
Flags: blocking-aviary1.5?

Updated

13 years ago
Attachment #190707 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 17

13 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Yup, looks like it works fine. Thank you. :)

And just to say, this was fun. :) Everybody was nice, and the bug got taken care
of in ten days. Sounds good to me.

Comment 19

13 years ago
*** Bug 303242 has been marked as a duplicate of this bug. ***

Updated

13 years ago
Blocks: 293527
Flags: blocking-aviary1.0.8+
Whiteboard: [can be fixed for firefox] → [can be fixed for firefox] (regression from 293527)
Attachment #190707 - Flags: approval-aviary1.0.8?
Attachment #190707 - Flags: approval-aviary1.0.8? → approval-aviary1.0.8+
aviary101/moz17 landing approval: a=dveditz for drivers. Please add the fixed1.7.13 and fixed-aviary1.0.8 keywords when landed.
Component: Menus → Build Config
Flags: review+
Product: Firefox → Core
Changed to relatively bogus component to get the blocking flags
Flags: blocking1.7.13+
Attachment #190707 - Flags: approval1.7.13+
Keywords: fixed-aviary1.0.8, fixed1.7.13
Apparently this caused bug 333035 on the old branches.
Depends on: 333035

Comment 23

12 years ago
Adding verified-aviary1.0.8 keyword based on testing of latest 1.0.8 respins (based on testcases from verified bug 333035, bug 333131, and bug 333305).
Keywords: fixed-aviary1.0.8 → verified-aviary1.0.8

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.