301875 - since 20050723: cannot install themes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050723 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050723 Firefox/1.0+

With build 20050323, it is apparently impossible to install a theme.

* dropping a theme jar file in the extensions folder just does nothing. Firefox
doesnot attempt to register the theme.
JS console reports the following
A Item Package appeared at: /Users/phiw/Library/Application
Support/Firefox/Profiles/1h0sbxi6.default/extensions/GrappleProP2.4.jar that we
know nothing about, assuming it was dropped in by the user and configuring for
installation now. Location Key: app-profile


Error: Components.classes['@mozilla.org/xpcom/version-comparator;1'] has no
properties
Source File:
file:///Applications/DeerPark.app/Contents/MacOS/components/nsExtensionManager.js
Line: 172

On starting up, the browser does not attempt to open the jar file and no warning
window appears (wnat to install something... Install - whatever the exact wordings.
The theme does not appear in the Theme manager.

* Downloading a theme from https://addons.mozilla.org/
results in the following:
- the theme downloads and briefly appears in the Theme manager window.
- when download finished, the theme vanishes out of the theme manager window.

Js console reports the following:
Error: Components.classes['@mozilla.org/xpcom/version-comparator;1'] has no
properties
Source File:
file:///Applications/DeerPark.app/Contents/MacOS/components/nsExtensionManager.js
Line: 172

Error: installLocation has no properties
Source File:
file:///Applications/DeerPark.app/Contents/MacOS/components/nsExtensionManager.js
Line: 6327

After restarting, the theme is not found in the extensions folder.

Reproducible: Always

Actual Results:  
no custom theme available

Expected Results:  
display the custom theme in the Theme Manager window, allow to activate.

I previously submitted bug 301872: Previously installed and active theme does
not display, browser reverts to default theme. Both bugs are related.

Comment 1

[Robert Strong (they/them - no direct email)]

The version-comparator was caused by bug 300731

The installLocation has no properties will be fixed by the patch in bug 296566

Comment 2

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/search?string=version-compar

I don't get it... didn't I get the contractid correct? What am I missing?

Comment 3

[James Ross]

I cannot find any problems with the comparator Contract ID and, more
importantly, installing themes from addons.mozilla.org works great in this
nightly build.

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b4) Gecko/20050724
Firefox/1.0+

I do however have a problem installing by dropping in the profile's extensions
folder, though a totally different one to the reporter. After the message about
a new file appearing, I get:

Error: commonName is not defined
Source File:
file:///C:/Program%20Files%20(x86)/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
Line: 2664

I am therefor unable to reproduce either part of the bug exactly, and only one
bit in net effect.

It also occurs to me that the bug says 2005*03*23. Is this a transcription error
for 20050723, the date it was filed and the buildID used? I guess it probably was.

Comment 4

[Benjamin Smedberg]

The "commonName" error is due to bug 240661... I'm suspecting now that
yesterday's nightly may have had had a mid-checkin tree causing the contractid
error.

Boris, did you mean to change commonName to prettyName at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in&mark=2673#2663

Comment 5

[philippe (part-time)]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050724
Firefox/1.0+ ID:2005072410

With this build, I was able to install a theme by downloading form
addons.mozilla.org. No problems at all, and the theme works.

*but*
I was unable to install a theme by dropping the jar file into the extension folder.

Js console:

A Item Package appeared at: /Users/phiw/Library/Application
Support/Firefox/Profiles/1h0sbxi6.default/extensions/GrappleProP2.4.jar that we
know nothing about, assuming it was dropped in by the user and configuring for
installation now. Location Key: app-profile

Error: commonName is not defined
Source File:
file:///Applications/DeerPark.app/Contents/MacOS/components/nsExtensionManager.js
Line: 2515

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Doh

Comment 7

[Boris Zbarsky [:bzbarsky]]

fixed.