Closed Bug 30204 Opened 26 years ago Closed 26 years ago

nsPrefMigration.cpp should called nsIPlatformCharset by using NS_WITH_SERVICE

Categories

(Core :: Preferences: Backend, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: ftang, Assigned: sspitzer)

References

Details

(Keywords: perf)

This is a performance problem . Part of 30201. nsIPlatformCharset is deisgned to be used as a service/singleton. The following places call it by CreateInstance, which cause peroformance problem- profile/pref-migrator/src/nsPrefMigration.cpp#2163 2161 // we may cache it since the platform charset will not change through application life 2162 nsCOMPtr <nsIPlatformCharset> platformCharset; 2163 rv = nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 2164 NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));
Blocks: 30201
cvsblame show sspitzer, add neeti to cc list
Assignee: neeti → sspitzer
performance issue add perf keyword
Keywords: perf
accepting, marking m15. this is a trival fix.
Status: NEW → ASSIGNED
Target Milestone: M15
fixed. I'm using do_GetService() now.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
qa->teruko's group?
Keywords: verifyme
QA Contact: sairuh → teruko
Changed QA contact to ftang.
QA Contact: teruko → ftang
You need to log in before you can comment on or make changes to this bug.