[track]nsIPlatformCharset should be called by using Service Manager

RESOLVED FIXED in Future

Status

()

defect
P3
normal
RESOLVED FIXED
20 years ago
19 years ago

People

(Reporter: ftang, Assigned: ftang)

Tracking

({meta, perf})

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Assignee

Description

20 years ago
this is a performnace problem.
nsIPlatformCharset is design to be an singleton service object. Create it 
multiple time is a performance problem. Somhow currently many places called by 
CreateInstance, which cause multiple copy of it get create. We should replace 
them by NS_WITH_SERVICE
Assignee

Comment 1

20 years ago
There are many places. I use this bug as tracking bug
Status: NEW → ASSIGNED
Assignee

Updated

20 years ago
Depends on: 30203
Assignee

Updated

20 years ago
Depends on: 30204
Assignee

Updated

20 years ago
Depends on: 30205
Assignee

Updated

20 years ago
Depends on: 30209
Assignee

Updated

20 years ago
Depends on: 30210
Assignee

Updated

20 years ago
Depends on: 30212
Assignee

Updated

20 years ago
Keywords: meta, perf
Assignee

Comment 2

20 years ago
By also fixing 30213, we can reduce a lot of unnecessary file reading.
Assignee

Updated

20 years ago
Depends on: 30213
Assignee

Updated

20 years ago
Summary: nsIPlatformCharset should be called by using Service Manager → [track]nsIPlatformCharset should be called by using Service Manager
Target Milestone: M15
Frank, how much performance improvement do we get from all this. When we looked 
only two instances were being created on startup adding to .14secs out of 19sec 
startup right ?

I can check my quantify data if you tell me something to look for and post the 
timings here. Then we can decide to fix this if we think the gain is high.

Updated

20 years ago
Blocks: 7251

Comment 4

20 years ago
I have changed most of the places to use the service manager in my local tree.
And saw most of the class store the result charset into static variable, so it 
won't call the interface as many times as originally expected.
nsFileSpec does not cache the result but the code is executed in limited 
condition (i.e., not used by most of the nsFileSpec instance).
Assignee

Updated

20 years ago
Blocks: 31758
Assignee

Updated

20 years ago
Target Milestone: M15 → M20

Updated

20 years ago
QA Contact: teruko → ftang
Assignee

Comment 5

19 years ago
this is a meta bug. Mark it as futre to make it out of the radar
Target Milestone: M20 → Future

Comment 6

19 years ago
It's fixed.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

Updated

19 years ago
No longer blocks: 7251
You need to log in before you can comment on or make changes to this bug.