Closed
Bug 30205
Opened 25 years ago
Closed 24 years ago
nsFileSpec should called nsIPlatformCharset by using do_GetService
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
VERIFIED
FIXED
M15
People
(Reporter: ftang, Assigned: nhottanscp)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
1.01 KB,
patch
|
Details | Diff | Splinter Review |
This is a performance problem . Part of 30201. nsIPlatformCharset is deisgned to be used as a service/singleton. The following places call it by CreateInstance, which cause peroformance problem- cvsblame show nhotta mozilla/xpcom/io/nsFileSpec.cpp 1130 nhotta 1.69 //------------------------------------------------------------------------------ ---------- 1131 void nsFileSpec::GetFileSystemCharset(nsString & fileSystemCharset) ... 1140 nsCOMPtr <nsIPlatformCharset> platformCharset; 1141 rv = nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 1142 NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset)); 1143 if (NS_SUCCEEDED(rv))
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M15
|
|
Assignee | |
Updated•25 years ago
|
Summary: nsFileSpec should called nsIPlatformCharset by using NS_WITH_SERVICE → nsFileSpec should called nsIPlatformCharset by using do_GetService
|
|
Assignee | |
Comment 2•25 years ago
|
||
|
|
Assignee | |
Comment 3•24 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Comment 4•24 years ago
|
||
- Per last comments, age of bug, and no reopen - Marking Verified/Fixed. Please reopen if still a problem.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•