Closed Bug 30205 Opened 26 years ago Closed 26 years ago

nsFileSpec should called nsIPlatformCharset by using do_GetService

Categories

(Core :: XPCOM, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ftang, Assigned: nhottanscp)

References

Details

(Keywords: perf)

Attachments

(1 file)

This is a performance problem . Part of 30201. nsIPlatformCharset is deisgned to be used as a service/singleton. The following places call it by CreateInstance, which cause peroformance problem- cvsblame show nhotta mozilla/xpcom/io/nsFileSpec.cpp 1130 nhotta 1.69 //------------------------------------------------------------------------------ ---------- 1131 void nsFileSpec::GetFileSystemCharset(nsString & fileSystemCharset) ... 1140 nsCOMPtr <nsIPlatformCharset> platformCharset; 1141 rv = nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 1142 NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset)); 1143 if (NS_SUCCEEDED(rv))
Blocks: 30201
performance issue add perf keyword
Keywords: perf
Status: NEW → ASSIGNED
Target Milestone: M15
Summary: nsFileSpec should called nsIPlatformCharset by using NS_WITH_SERVICE → nsFileSpec should called nsIPlatformCharset by using do_GetService
Attached patch patch — — Splinter Review
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
- Per last comments, age of bug, and no reopen - Marking Verified/Fixed. Please reopen if still a problem.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: