30209 - widget code should called nsIPlatformCharset by using do_GetService

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Frank Tang]

This is a performance problem . Part of 30201. 
nsIPlatformCharset is deisgned to be used as a service/singleton. The following 
places call it by CreateInstance, which cause peroformance problem-

cvsblame show nhotta
mozilla/widget/src/gtk/nsFileWidget.cpp
416 nhotta   1.37   // Create an unicode converter for file system charset
417                 if (nsnull == gUnicodeEncoder) {
418                     nsAutoString localeCharset;
419               
420                     nsCOMPtr <nsIPlatformCharset> platformCharset;
421                     rv = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
422                                                             
NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));
423 


mozilla/widget/src/mac/nsMacControl.cpp
596                       nsCOMPtr <nsIPlatformCharset> platformCharset;
597                       rv = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
598                                                               
NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));


widget/src/windows/nsFileWidget.cpp#381
380     nsCOMPtr <nsIPlatformCharset> platformCharset;
381     rv = nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, 
nsnull, 
382                                             NS_GET_IID(nsIPlatformCharset), 
getter_AddRefs(platformCharset));

Comment 1

[Frank Tang]

performance issue add perf keyword

Comment 2

[nhottanscp]

Attachment: patch

Comment 3

[nhottanscp]

fix checked in