30210 - nsPrimitiveHelpers.cpp should called nsIPlatformCharset by using do_GetService

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Frank Tang]

This is a performance problem . Part of 30201. 
nsIPlatformCharset is deisgned to be used as a service/singleton. The following 
places call it by CreateInstance, which cause peroformance problem-

cvsblame show pinkerton

mozilla/widget/src/xpwidgets/nsPrimitiveHelpers.cpp

147                   nsCOMPtr <nsIPlatformCharset> platformCharsetService;
148                   nsAutoString platformCharset;
149                   nsresult res = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
150                                                                      
NS_GET_IID(nsIPlatformCharset), 
151                                                                      
getter_AddRefs(platformCharsetService));
152                   if (NS_SUCCEEDED(res))



202                   nsCOMPtr <nsIPlatformCharset> platformCharsetService;
203                   nsAutoString platformCharset;
204                   nsresult res = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
205                                                                      
NS_GET_IID(nsIPlatformCharset), 
206                                                                      
getter_AddRefs(platformCharsetService));

Comment 1

[Frank Tang]

also mozilla/widget/src/xpwidgets/nsXIFFormatConverter.cpp

288                    nsCOMPtr <nsIPlatformCharset> platformCharsetService;
289                    nsresult res = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
290                                                                       
NS_GET_IID(nsIPlatformCharset), 
291                                                                       
getter_AddRefs(platformCharsetService));

Comment 2

[Frank Tang]

performance issue add perf keyword

Comment 3

[nhottanscp]

I have same kind of bug in other places, reassign to me.

Comment 4

[nhottanscp]

Attachment: patch

Comment 5

[nhottanscp]

fix checked in