Closed
Bug 30210
Opened 25 years ago
Closed 25 years ago
nsPrimitiveHelpers.cpp should called nsIPlatformCharset by using do_GetService
Categories
(Core :: XUL, defect, P3)
Core
XUL
Tracking
()
RESOLVED
FIXED
M15
People
(Reporter: ftang, Assigned: nhottanscp)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
4.28 KB,
patch
|
Details | Diff | Splinter Review |
This is a performance problem . Part of 30201.
nsIPlatformCharset is deisgned to be used as a service/singleton. The following
places call it by CreateInstance, which cause peroformance problem-
cvsblame show pinkerton
mozilla/widget/src/xpwidgets/nsPrimitiveHelpers.cpp
147 nsCOMPtr <nsIPlatformCharset> platformCharsetService;
148 nsAutoString platformCharset;
149 nsresult res =
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull,
150
NS_GET_IID(nsIPlatformCharset),
151
getter_AddRefs(platformCharsetService));
152 if (NS_SUCCEEDED(res))
202 nsCOMPtr <nsIPlatformCharset> platformCharsetService;
203 nsAutoString platformCharset;
204 nsresult res =
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull,
205
NS_GET_IID(nsIPlatformCharset),
206
getter_AddRefs(platformCharsetService));
|
Reporter | |
Comment 1•25 years ago
|
||
also mozilla/widget/src/xpwidgets/nsXIFFormatConverter.cpp
288 nsCOMPtr <nsIPlatformCharset> platformCharsetService;
289 nsresult res =
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull,
290
NS_GET_IID(nsIPlatformCharset),
291
getter_AddRefs(platformCharsetService));
|
Assignee | |
Comment 3•25 years ago
|
||
I have same kind of bug in other places, reassign to me.
Assignee: pinkerton → nhotta
|
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M15
|
|
Assignee | |
Updated•25 years ago
|
Summary: nsPrimitiveHelpers.cpp should called nsIPlatformCharset by using NS_WITH_SERVICE → nsPrimitiveHelpers.cpp should called nsIPlatformCharset by using do_GetService
|
|
Assignee | |
Comment 4•25 years ago
|
||
|
|
Assignee | |
Comment 5•25 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•