30212 - nsMsgI18N.cpp should called nsIPlatformCharset by using do_GetService

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[Frank Tang]

This is a performance problem . Part of 30201. 
nsIPlatformCharset is deisgned to be used as a service/singleton. The following 
places call it by CreateInstance, which cause peroformance problem-


cvsblame show ducarroz

mailnews/base/util/nsMsgI18N.cpp
223                             nsCOMPtr <nsIPlatformCharset> platformCharset;
224                             nsresult rv = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
225                                                  
NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));

Comment 1

[Frank Tang]

performance issue, add perf keyword

Comment 2

[nhottanscp]

I have same kind of bug in other places, reassign to me.

Comment 3

[nhottanscp]

Attachment: patch

Comment 4

[nhottanscp]

fix checked in

Comment 5

[Katsuhiko Momoi]

Naoki, is this a kind of problem which can be observed to 
have been fixed in a published build? If so, leave it 
assigned to me. Otherwise, can you get yourself assigned as
QA contact?

Comment 6

[Katsuhiko Momoi]

No response from the engineer on the question.
The code changaes are in

mailnews/base/util/nsMsgI18N.cpp

I don't knwo if this actually resulted in real performance 
gain but will mark it verified as fixed based on the existence
of changes in the source file.