This is a performance problem . Part of 30201. nsIPlatformCharset is deisgned to be used as a service/singleton. The following places call it by CreateInstance, which cause peroformance problem- cvsblame show ducarroz mailnews/base/util/nsMsgI18N.cpp 223 nsCOMPtr <nsIPlatformCharset> platformCharset; 224 nsresult rv = nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 225 NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));
performance issue, add perf keyword
I have same kind of bug in other places, reassign to me.
Assignee: ducarroz → nhotta
Target Milestone: M15
Summary: nsMsgI18N.cpp should called nsIPlatformCharset by using NS_WITH_SERVICE → nsMsgI18N.cpp should called nsIPlatformCharset by using do_GetService
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
Naoki, is this a kind of problem which can be observed to have been fixed in a published build? If so, leave it assigned to me. Otherwise, can you get yourself assigned as QA contact?
No response from the engineer on the question. The code changaes are in mailnews/base/util/nsMsgI18N.cpp I don't knwo if this actually resulted in real performance gain but will mark it verified as fixed based on the existence of changes in the source file.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.