Closed Bug 30212 Opened 24 years ago Closed 24 years ago

nsMsgI18N.cpp should called nsIPlatformCharset by using do_GetService

Categories

(MailNews Core :: Internationalization, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ftang, Assigned: nhottanscp)

References

Details

(Keywords: perf)

Attachments

(1 file)

This is a performance problem . Part of 30201. 
nsIPlatformCharset is deisgned to be used as a service/singleton. The following 
places call it by CreateInstance, which cause peroformance problem-


cvsblame show ducarroz

mailnews/base/util/nsMsgI18N.cpp
223                             nsCOMPtr <nsIPlatformCharset> platformCharset;
224                             nsresult rv = 
nsComponentManager::CreateInstance(NS_PLATFORMCHARSET_PROGID, nsnull, 
225                                                  
NS_GET_IID(nsIPlatformCharset), getter_AddRefs(platformCharset));
Blocks: 30201
performance issue, add perf keyword
Keywords: perf
I have same kind of bug in other places, reassign to me.
Assignee: ducarroz → nhotta
Target Milestone: M15
Status: NEW → ASSIGNED
Summary: nsMsgI18N.cpp should called nsIPlatformCharset by using NS_WITH_SERVICE → nsMsgI18N.cpp should called nsIPlatformCharset by using do_GetService
Attached patch patchSplinter Review
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Naoki, is this a kind of problem which can be observed to 
have been fixed in a published build? If so, leave it 
assigned to me. Otherwise, can you get yourself assigned as
QA contact?
No response from the engineer on the question.
The code changaes are in

mailnews/base/util/nsMsgI18N.cpp

I don't knwo if this actually resulted in real performance 
gain but will mark it verified as fixed based on the existence
of changes in the source file.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.