Closed
Bug 30213
Opened 24 years ago
Closed 24 years ago
ns{Win,Mac,UNIX}Charset.cpp should only load nsURLProperties once
Categories
(Core :: Internationalization, defect, P3)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
M16
People
(Reporter: ftang, Assigned: ftang)
References
Details
(Keywords: perf)
When I first create mozilla/intl/uconv/src/ns{Win,Mac,UNIX}Charset.cpp I create the nsURLProperties as local, use it and cache the result in member data , then release it in the local variable and then delete it because I really need to look at it once. When nhotta add new method to the interface GetDefaultCharsetForLocale, he duplicate to code without making the nsURLProperties as a member data and destroy only in the destructor. This cause performance problem. We create a nsURLProperties once every time we call GetDefaultCharsetForLocale, which is a performace hit. We should move the nsURLProperties as an member data and destory only in the destructor. Fix this and ALL the bugs tracek 30201 can reduce a lot of file reading time.
Comment 2•24 years ago
|
||
> When nhotta add new method to the interface GetDefaultCharsetForLocale, not me, look as cvsblame, http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/intl/uconv/src/nsWinCharset. cpp
Assignee: nhotta → ftang
Assignee | ||
Comment 3•24 years ago
|
||
I am sorry that I didn't check cvsblame and just use stupid_ftang_blame to blame nhotta. I take it back. It is tague did that. I will take this back and fix it.
Status: NEW → ASSIGNED
Assignee | ||
Updated•24 years ago
|
Target Milestone: M16
Assignee | ||
Comment 4•24 years ago
|
||
fix and check in for all 3 platforms
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•