302153 - Thunderbird Mac builds fail at runtime due to XML parsing error

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Josh Aas]

XML Parsing Error: undefined entity
Location: chrome://messenger/content/messenger.xul
Line Number 20, Column 1:<window id="messengerWindow"
^  <broadcaster id="Communicator:WorkMode"
--^          <menuitem id="hintsAndTips" label="&hintsAndTips.label;"
key="key_macHelp" oncommand="loadThrobberUrl('mailnews.hints_and_tips.url');"/>
----------^

This happens on all my fresh tbird builds tonight.

Comment 1

[Scott MacGregor]

The 7/25 nightly build runs ok so it must be something that was checked in
today. I did a fresh build around 3pm today and that build ran ok too.

Comment 2

[Asaf Romano (gone)]

It also happens in the profile manager, so this isn't really an entity issue,
Maybe something isn't packaged?

Comment 3

[Scott MacGregor]

I'm seeing this on Windows too now with a clobber build from this morning.

It looks like the branding files are no longer showing up in the debug builds. I
see a console error complaining about not finding the chrome url for
brand.properties. Looking in en-US.jar, I don't see any branding related string
files. Any ideas Benjamin?

Comment 4

[Scott MacGregor]

I found Bug 269460 which looked like it could be the culprit as it got checked
in yesterday. 

Comment 5

[Benjamin Smedberg]

Are the broken builds --enable-official-branding or not?

Comment 6

[Scott MacGregor]

debug builds do not build official branding (by default)

Comment 7

[Scott MacGregor]

Attachment: fix the regression

Comment 8

[Scott MacGregor]

i went ahead and checked this in so we can get debug builds going again. Feel
free to correct my fix if you don't like it Benjamin :)

Comment 9

[Benjamin Smedberg]

Comment on attachment 190642 [details] [diff] [review]
fix the regression

ex-post-facto r+

Comment 10

[Scott MacGregor]

I put this in 269460:

"Benjamin, I was able to fix the problem with no branding property files showing
up in non official builds. But now today's nightly (with official branding) is
getting the generic branding.

Welcome to Mail/News!

Instead of Welcome to Thunderbird"