302495 - Page setup and Print preview fails

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[Hari Kumar G]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+

The print priview zoom values as well as page setup zoom / orientation is not
working in nightly builds of Ffx 1.5

Reproducible: Always

Steps to Reproduce:
1.Open a web page in a recent build of Ffx 1.0 +,
2.Choose print preview from the file menu.  CLick the page setup from the menu
3.Adjust the zoom value/ portrait-landscape etc. Click Ok.

Actual Results:  
Nothing

Expected Results:  
Zoom should be adjusted to the value opted from the dialog.  So the orientation
of the page.

Is it broken in the nightly builds or temporarily disabled due to the
modifications in nightlies?

Comment 1

[shadytrees]

The prefs seem to be broken in general. See
https://bugzilla.mozilla.org/show_bug.cgi?id=267422#c26

Comment 2

[Bryan]

Confirmed!

Attempting to use "Shrink to Fit" and or switching between "Portrait" and
"Landscape" the JCON Reports: Error: uncaught exception: [Exception...
"Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIPrintSettingsService.savePrintSettingsToPrefs]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/printUtils.js :: anonymous :: line 86"  data: no]

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050802
Firefox/1.0+ ID:2005080209

Comment 3

[Frank Wein [:mcsmurf]]

no need for two blocking? flags

Comment 4

[Mike Schroepfer]

Josh,

Can you take a first pass to help us narrow down either a fix or a better owner
for this?

Comment 5

[Hari Kumar G]

As far I remember this bug was there as early as builds from July 20, 2005.

Comment 6

[Tracy Walker [:tracy]]

I spent a few hours looking at archived builds and checkins in attempt to
determine when things happened. Print preview on the trunk has regressed over
several months.  

There is some print preview display ugliness, bug 267422, which is blocked by
this bug.  That bug has been around since at least 2004-11-02.

The preview controls broke at two different times:
In the Main Print Preview window, The scale tool and orientation buttons broke
between builds 2004-12-19-08-trunk (works) and 2004-12-20-08-trunk (broken). 
That bustage was reported immediately in bug 275387.  However, it wasn't
confirmed until I did the first BFT run against the trunk on 2005-05-18.  

At that time, I discovered that the Scale function in Page Setup was stuck on
shrink-to-fit. It also regressed on the 2004-12-20 build.  Although sometime
between Dec '04 and the build on 2005-05-18 that was fixed.

But then both Orientation and Scale in Print Preview | Page Setup broke between
builds 2005-07-19-06-trunk (works) and 2005-07-20-07-trunk (broken as Hari stated)

A checkin involving print for bug 270079 landed in the regression window for the
main page controls.
Then a checkin involving print for bug 297277 landed during the regression
window for the Page Setup controls.
Both of those fixes were in nsPrintOptionsImpl.cpp
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/gfx/src/nsPrintOptionsImpl.cpp

Comment 7

[Tracy Walker [:tracy]]

*** Bug 275387 has been marked as a duplicate of this bug. ***

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
>... 
> The print priview zoom values as well as page setup zoom / orientation is not
> working in nightly builds of Ffx 1.5

More precisely, it does not redraw the screen with new setting after using menu
options or buttons or changing via "page setup".

However, if you exit print preview after using "page setup" then print preview
displays with those options.

Happens for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050808 Firefox/1.0+ on XP home.

but I don't get precisely the same behavior with Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050816 Firefox/1.0+ on XP-PRO. There I
get bug 267422.

Comment 9

[O. Atsushi (Torisugari)]

This is just my guess of bug 267422:

We, in printPreviewBindings.xml and printUtils.js, assume a settings
(I mean, an object which has nsIPrintSettings interface) from
nsIPrintSettingsService::globalSettings modified with 
...::initPrintSettingsFromPrinter and ...::initPrintSettingsFromPrefs
should be same as the settings nsIWebBrowserPrint::currentPrintSettings
returns. (Ummmm, confusing...)

However, as mentioned comment #6, the fix for bug 270079 changed the behavior
of ...::globalSettings, then it always returns the initial settings
instead of the current settings.

We are calling globalSettings everytime the user resize the print preview,
but probably that's a evil implementation.

According to 270079c#2,
> Change this will not change the performance, since this function
> will only be invoked two times, when browser start printing/preview
> and when mailnews start priting/preview.

Comment 10

[O. Atsushi (Torisugari)]

Attachment: Patch

UIs will be back.

Anyone knows there's a similar bug on seamonkey as well?

Comment 11

[Jesse Ruderman]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050831
Firefox/1.0+

Torisugari, does your patch fix this bug or a different bug?

Comment 12

[Josh Aas]

WFM Firefox 1.5 brnach build from today (see time of this post).

torisugari: what does your patch fix?

Comment 13

[O. Atsushi (Torisugari)]

Uhm, I believed I was talking about this bug, but now I'm not too sure.
I can still reproduce this(?) bug with today's branch/trunk + a new profile.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050901 Firefox/1.0+

Steps to reproduce:
1. "File" -> "Print Preview"
2. Push "Landscape" button.

Actual result:
That functionality works, but the landscape button is not "in".

Expected result:
If a user push these buttons, they should look pushed.


Print preveiw toolbar's "orient()" method tries to change the buttons status,
but "updateToolbar()" method switch back that status.

Anyway, the script sets

this.mLandscapeButton.checked = true/false;

too many times.

Comment 14

[Asa Dotzler [:asa]]

not failing for us on 1.5. unsetting request.

Comment 15

[Tracy Walker [:tracy]]

torisugari,  Are you certain the functionality of the main preview orientation
buttons are working?  It's still broken for me. Please see bug 275387. Also bug
267422 can make it difficult to tell without resizing the window.

Comment 16

[Sebastian P. Goetze]

Has the patch been checked in somewhere ?

(In reply to comment #14)
> not failing for us on 1.5. unsetting request.

OK, it DOES work, if you change settings in the Print Setup Dialog.
(Did you notice the funny change of the bottom line, if you toggle between
Portrait and Landscape, BTW) - And the redraw isn't right (bug 267422 ?).

But the direct settings (Scale, and the Portrait/Landscape Buttons) don't work
at all. Seing that Bug 275387 is reopened (used to be a dupe of this one),
shouldn't that one be set to block instead? 
(I'll request that... I use Print Preview a lot, and it not properly working
would block me from upgrading 1.0.6   :-(  )

Comment 17

[Hari Kumar G]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050906 Firefox/1.4

isn't that a regression serious enough to be resolved before firefox 1.5?

Comment 18

[dirio49]

(In reply to comment #17)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050906
Firefox/1.4
> 
> isn't that a regression serious enough to be resolved before firefox 1.5?

i agree this should be fixed before it is released

Comment 19

[Asa Dotzler [:asa]]

we're blocking on the two bugs mentioned in comment #16. I think that's
sufficient. if you disagree, please renominate with an explanation of what's
still failing here that's not covered in those bugs. Thanks.

Comment 20

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 194007 [details] [diff] [review]
Patch

I've got a better fix for this coming

Comment 21

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

fixed with check-in for bug 267422.