302581 - Show "install" dialog for single extension updates as well as multiple

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Basson]

If multiple extension updates are found by the EM (when manually checking with
"Find Updates") a dialog is presented which lists them prompts the user to install. 

Currently, a single update is displayed only with the red arrow and the "Update
Now" button. The problem with this situation is that the single extension could
be out of the current view, requiring the user to scroll before they realise
that an update is available. 

To work around this, the same dialog that is launched for multiple updates
should be used for single updates, when manually checking with the "Find
Updates" button.

Comment 1

[Ben Basson]

Asa, this might affect l10n if Rob is adding a progress indicator with new
strings as part of this patch (if at all).

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch (fixes more than this bug)

The recent update changes have caused a couple of issues which this patch
addresses by restoring the previous wizard when checking for updates to more
than one item. The issues are:
1) This bug. By using the wizard when checking updates for multiple items the
wizard will show there is an update and give the user the option to install it
whereas the current behavior is if only one update is available and the item is
not in view the user will not see any indication that there is an update
available.
2) bug 302273. This restores the old behavior when checking for updates from
options.
3) Thunderbird extension update from options is broken. This restores the old
behavior when checking for updates from options.
4) On upgrade _upgradeThemeChrome can be skipped in _finishOperations.
5) What I believe caused the upgradeExtensionChrome failure in bug 302527. If
an item no longer exists in the file system during an upgrade then the metadata
needs to be removed.
6) Clicking finish on the update wizard during an upgrade fails due to a
constant name change (e.g. PREF_EXTENSIONS_UPDATE_ENABLED was changed to
PREF_UPDATE_EXTENSIONS_ENABLED).
7) When performing an update the update commands are enabled.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 191142 [details] [diff] [review]
patch (fixes more than this bug)

Since there is no additional review I'm asking Ben for sr due to this restoring
some of the recent changes he made.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

No, don't restore the old wizard. If there are bugs with the current impl we
need to fix those, rather than backing away.

I think the extensions window is probably missing a call to
ensureElementIsVisible or something. 

Comment 5

[Ben Basson]

Ben, if it helps, I listed the problems I have with the new system at the thread
in the URL field above.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch

Thanks Ben.

This addresses this bug by using scrollToElement... this will bring the item
that has an update into view and make it the first viewable item in the list
which is more noticeable than using ensureElementIsVisible.

I removed the calls to LOG due to errors these cause when closing the EM during
a find updates. Also, the commands are now disabled during an update.

Comment 7

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.71; previous revision: 1.70

Note: there is also bug 303191 regarding displaying a progress indicator