Closed Bug 302668 Opened 19 years ago Closed 19 years ago

Blank buttons show up in Extension Manager on OS X when updates are available

Categories

(Toolkit :: Add-ons Manager, defect)

PowerPC
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.8final

People

(Reporter: uriber, Assigned: robert.strong.bugs)

Details

(Keywords: regression)

Attachments

(2 files)

In the Extension Manager, the button next to an extension which has an available
updae is blank.

Notice that bug 302272 removed the blank buttons from where they shouldn't
appear at all. However, the button is still blank when it does appear.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050728
Firefox/1.0+
Attached image screenshot
Notice the blank button on "Gmail Notifier".
Flags: blocking1.8b4?
Summary: Blank buttons show up when updates are available in Extension Manager on OS X → Blank buttons show up in Extension Manager on OS X when updates are available
Assignee: nobody → joshmoz
Flags: blocking1.8b4? → blocking1.8b4+
Josh,

Can you take a first look at let us know if someone else should take this?
I adjusted this yesterday, bug 249956 It seems to be a core bug shared with
Thunderbird.
Attached patch simple patchSplinter Review
pinstripe doesn't display button text for the buttons at th bottom. To
accomplish this .button-text { display: none } was used and the patch just
makes the selector more specific so the uupdate now button text is displayed.
Assignee: joshmoz → rob_strong
Status: NEW → ASSIGNED
Attachment #191034 - Flags: review?(benjamin)
Attachment #191034 - Flags: review?(benjamin) → review+
Attachment #191034 - Flags: approval1.8b4?
Attachment #191034 - Flags: approval1.8b4? → approval1.8b4+
Whiteboard: [checkin needed][a+]
Checking in extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.14; previous revision: 1.13
done
Whiteboard: [checkin needed][a+]
Target Milestone: --- → Firefox1.1
Fixed on trunk... thanks again Gavin!
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: